Re: RFR: 8327793: Deprecate jstatd for removal [v4]

2024-06-11 Thread Kevin Walls
and configuration difficulties with firewalls. > > The jstatd tool should be removed. Deprecating and removing jstatd will not > affect usage of jstat for monitoring local VMs using the Attach API. Kevin Walls has updated the pull request incrementally with one additional com

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 17:03:58 GMT, Weijun Wang wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean comments > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMICo

Re: RFR: 8327793: Deprecate jstatd for removal [v3]

2024-06-11 Thread Kevin Walls
and configuration difficulties with firewalls. > > The jstatd tool should be removed. Deprecating and removing jstatd will not > affect usage of jstat for monitoring local VMs using the Attach API. Kevin Walls has updated the pull request incrementally with two additional comm

Re: RFR: 8327793: Deprecate jstatd for removal [v2]

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 16:54:36 GMT, Kevin Walls wrote: >> jstatd is an RMI server application which monitors HotSpot VMs, and provides >> an interface to the monitoring tool jstat, for use across a remote RMI >> connection. >> >> RMI is not how modern applicat

Re: RFR: 8327793: Deprecate jstatd for removal

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 13:35:19 GMT, Alan Bateman wrote: > The sun.jvmstat.monitor.remote package is not exported so I don't think > adding `@Deprecated` makes sense. Sure, happy to not add annotations in sun.jvmstat.monitor.remote (RemoteHost.java, RemoteVm.java). - PR Comment:

Re: RFR: 8327793: Deprecate jstatd for removal [v2]

2024-06-11 Thread Kevin Walls
and configuration difficulties with firewalls. > > The jstatd tool should be removed. Deprecating and removing jstatd will not > affect usage of jstat for monitoring local VMs using the Attach API. Kevin Walls has updated the pull request incrementally with one additional com

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v2]

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 14:02:17 GMT, Sean Mullan wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More consistent style of calls and comments. > > test/jdk/javax/man

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-11 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Wa

RFR: 8327793: Deprecate jstatd for removal

2024-06-11 Thread Kevin Walls
jstatd is an RMI server application which monitors HotSpot VMs, and provides an interface to the monitoring tool jstat, for use across a remote RMI connection. RMI is not how modern applications communicate. It is an old transport with long term security concerns, and configuration difficulties

Re: RFR: 8322811: jcmd System.dump_map help info has conflicting statements

2024-06-11 Thread Kevin Walls
On Mon, 10 Jun 2024 17:08:58 GMT, Chris Plummer wrote: >> @dholmes-ora this is one of yours. >> >> This was a tad annoying to fix (fix is simple though), since the jcmd >> framework has no good way to allow for default parameters that are not used >> literally. E.g. in this case, the real

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v2]

2024-06-10 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Wa

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed

2024-06-10 Thread Kevin Walls
On Mon, 10 Jun 2024 14:28:25 GMT, Alan Bateman wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >>

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed

2024-06-10 Thread Kevin Walls
On Mon, 10 Jun 2024 11:28:28 GMT, Kevin Walls wrote: > JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.s

RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed

2024-06-10 Thread Kevin Walls
JMX uses APIs related to the Security Mananger which are deprecated. Use of AccessControlContext will be removed when Security Manager is removed. Until then, updates are needed to not require setting -Djava.security.manager=allow to use JMX authentication. - Commit messages: -

Re: RFR: 8322811: jcmd System.dump_map help info has conflicting statements

2024-06-10 Thread Kevin Walls
On Fri, 7 Jun 2024 10:40:07 GMT, Thomas Stuefe wrote: > @dholmes-ora this is one of yours. > > This was a tad annoying to fix (fix is simple though), since the jcmd > framework has no good way to allow for default parameters that are not used > literally. E.g. in this case, the real value for

Re: RFR: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"

2024-06-06 Thread Kevin Walls
On Thu, 6 Jun 2024 02:12:11 GMT, Alex Menkov wrote: > The fix updates com/sun/tools/attach/BasicTests.java to listen and connect > using loopback addresses > > Testing: run the test on all Oracle-supported platforms Marked as reviewed by kevinw (Reviewer). - PR Review:

Re: RFR: 8332919: SA PointerLocation needs to print a newline after dumping java thread info for JNI Local Ref

2024-05-28 Thread Kevin Walls
On Fri, 24 May 2024 20:03:53 GMT, Chris Plummer wrote: > If PointerLocation discovers that an address is for a JNI local ref, it will > print information about the thread that owns the JNI local ref. For > JavaThreads it calls the printThreadIDOn(tty) method. There's a comment on > the call

Integrated: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-24 Thread Kevin Walls
On Wed, 15 May 2024 16:59:59 GMT, Kevin Walls wrote: > Running JConsole from a previous JDK, and attaching to jdk-23 (after > [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java > Management Extension (JMX) Subject Delegation feature), the MBean tab is

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v6]

2024-05-24 Thread Kevin Walls
On Fri, 24 May 2024 18:22:18 GMT, Kevin Walls wrote: >> Running JConsole from a previous JDK, and attaching to jdk-23 (after >> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java >> Management Extension (JMX) Subject Delegation feature), the MBea

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v5]

2024-05-24 Thread Kevin Walls
On Fri, 24 May 2024 18:04:20 GMT, Chris Plummer wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove should... from delegationSubjects param > > src/java.management.rmi/share/class

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v6]

2024-05-24 Thread Kevin Walls
> > Manually testing JConsole, the MBean tab is fully populated and usable. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: entries consistency in param and throws text - Changes: - all: https://git.openjdk.org

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v5]

2024-05-24 Thread Kevin Walls
> > Manually testing JConsole, the MBean tab is fully populated and usable. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: remove should... from delegationSubjects param - Changes: - all: https://git.openjdk.org

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v3]

2024-05-24 Thread Kevin Walls
On Fri, 24 May 2024 16:49:25 GMT, Chris Plummer wrote: >> Thanks, appreciate the effort trying to make it perfect. >> Can't quite say "must be null or an array of all null entries" ..because I >> suppose it could be an empty array. >> >> In reality, the only caller is our code that wraps a

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v3]

2024-05-24 Thread Kevin Walls
On Fri, 24 May 2024 15:50:00 GMT, Chris Plummer wrote: >> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java >> line 961: >> >>> 959: * @param delegationSubjects should be {@code null}, but a non-null >>> 960: * array is also accepted for

Re: RFR: 8332641: Update nsk.share.jpda.Jdb to don't use finalization

2024-05-24 Thread Kevin Walls
On Tue, 21 May 2024 21:49:51 GMT, Leonid Mesnik wrote: > The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and > output streams. > > The fix renames the method to close() and calls it explicitly after the test > finishes. I verified that close() called for each nsk share

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-20 Thread Kevin Walls
On Thu, 16 May 2024 08:25:17 GMT, Kevin Walls wrote: >>> > ...Is there any way to run jconsole in a way that would result in it >>> > passing a non-empty delegationSubjects, resulting in this issue still >>> > reproducing? >>> >>> I don't

Re: RFR: 8332071: Convert package.html files in `java.management.rmi` to package-info.java

2024-05-20 Thread Kevin Walls
On Thu, 16 May 2024 10:39:43 GMT, Nizar Benalla wrote: > Please review this change. I converted the `package.html` file to > `package-info.java`, because `javac` cannot recognize `package.html`. > I already brought this up [in the mailing >

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v4]

2024-05-17 Thread Kevin Walls
> > Manually testing JConsole, the MBean tab is fully populated and usable. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: UOE doc correction - Changes: - all: https://git.openjdk.org/jdk/pull/19253/files - n

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v3]

2024-05-17 Thread Kevin Walls
On Fri, 17 May 2024 10:14:43 GMT, Daniel Fuchs wrote: >> Kevin Walls has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - add an 'also' >> - typo > > src/java.management.rmi/share/classes/javax/mana

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v2]

2024-05-16 Thread Kevin Walls
On Thu, 16 May 2024 19:53:48 GMT, Sean Mullan wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> IllegalArgumentException throws doc update > > src/java.management.rmi/share/class

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v3]

2024-05-16 Thread Kevin Walls
> > Manually testing JConsole, the MBean tab is fully populated and usable. Kevin Walls has updated the pull request incrementally with two additional commits since the last revision: - add an 'also' - typo - Changes: - all: https://git.openjdk.org/jdk/pull/19253/files

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v7]

2024-05-16 Thread Kevin Walls
On Thu, 16 May 2024 15:31:15 GMT, Chris Plummer wrote: >> This PR adds ranked monitor support to the debug agent. The debug agent has >> a large number of monitors, and it's really hard to know which order to grab >> them in, and for that matter which monitors might already be held at any >>

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v7]

2024-05-16 Thread Kevin Walls
On Thu, 16 May 2024 15:31:15 GMT, Chris Plummer wrote: >> This PR adds ranked monitor support to the debug agent. The debug agent has >> a large number of monitors, and it's really hard to know which order to grab >> them in, and for that matter which monitors might already be held at any >>

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v2]

2024-05-16 Thread Kevin Walls
On Thu, 16 May 2024 11:38:28 GMT, Daniel Fuchs wrote: >> Yes, completely understand. I just don't think it has any benefit. > > Hmmm... the spec still says: > > * @throws IllegalArgumentException if names or > * filters is null, or if names contains > * a null element, or if the

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v2]

2024-05-16 Thread Kevin Walls
> > Manually testing JConsole, the MBean tab is fully populated and usable. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: IllegalArgumentException throws doc update - Changes: - all: https://git.openjdk.org

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-16 Thread Kevin Walls
On Thu, 16 May 2024 10:26:25 GMT, Daniel Fuchs wrote: >> That the JConsole tab was blank shows that the older RMIConnector's >> addListenerWithSubject creates a new single-entry array from the given >> delegationSubject (which is null) and passes it onwards. The app is not >> creating the

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-16 Thread Kevin Walls
On Thu, 16 May 2024 09:40:58 GMT, Daniel Fuchs wrote: >> That seems pretty extreme -- it's an array we explicitly don't want and are >> going to ignore? If somebody passes a non-null member, we will throw as >> unsupported. I was thinking that was enough, hence removing the sbjs array >> to

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-16 Thread Kevin Walls
On Wed, 15 May 2024 22:44:03 GMT, Serguei Spitsyn wrote: >> Running JConsole from a previous JDK, and attaching to jdk-23 (after >> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java >> Management Extension (JMX) Subject Delegation feature), the MBean tab is >> blank.

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-16 Thread Kevin Walls
On Wed, 15 May 2024 23:40:00 GMT, Chris Plummer wrote: > If jconsole is passing null, why is it triggering this exception? JConsole passes null, but when running on an older jdk, the older RMIConnector actually "promotes" it to an array before making the remote call. If you connect to a

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-15 Thread Kevin Walls
On Wed, 15 May 2024 21:20:25 GMT, Chris Plummer wrote: > ...Is there any way to run jconsole in a way that would result in it passing > a non-empty delegationSubjects, resulting in this issue still reproducing? I don't think there is, JConsole has a hard null in this call. Also I don't see

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-15 Thread Kevin Walls
On Wed, 15 May 2024 19:09:54 GMT, Chris Plummer wrote: > I'm just trying to understand current and previous behavior of jconsole a bit > better. Right, to be clear it's not JConsole's fault. The early part of JConsole's stack is: ...connection at

Re: RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-15 Thread Kevin Walls
On Wed, 15 May 2024 17:49:07 GMT, Daniel Fuchs wrote: >> Running JConsole from a previous JDK, and attaching to jdk-23 (after >> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java >> Management Extension (JMX) Subject Delegation feature), the MBean tab is >> blank. >>

RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation

2024-05-15 Thread Kevin Walls
Running JConsole from a previous JDK, and attaching to jdk-23 (after [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java Management Extension (JMX) Subject Delegation feature), the MBean tab is blank. In javax/management/remote/rmi/RMIConnectionImpl.java:

Integrated: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists

2024-05-09 Thread Kevin Walls
On Wed, 8 May 2024 17:05:30 GMT, Kevin Walls wrote: > Remove from zgc problemlists. > Trivial fix. > > This was omitted when https://bugs.openjdk.org/browse/JDK-8303136 was > integrated. > > I see the tests passing, including with ZGC. Just ran my own batch of

Re: RFR: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists

2024-05-09 Thread Kevin Walls
On Wed, 8 May 2024 17:05:30 GMT, Kevin Walls wrote: > Remove from zgc problemlists. > Trivial fix. > > This was omitted when https://bugs.openjdk.org/browse/JDK-8303136 was > integrated. > > I see the tests passing, including with ZGC. Just ran my own batch of

Re: RFR: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed

2024-05-09 Thread Kevin Walls
On Thu, 2 May 2024 10:07:35 GMT, Serguei Spitsyn wrote: > Any event posting code except CFLH, ClassPrepare and ClassLoad events has a > conditional return in case if the event is posted during a VTMS transition. > The CFLH, ClassPrepare and ClassLoad event posting code has just an assert >

RFR: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists

2024-05-09 Thread Kevin Walls
Remove from zgc problemlists. This was omitted when https://bugs.openjdk.org/browse/JDK-8303136 was integrated. I see the tests passing, including with ZGC. Just ran my own batch of tests in addition, and it includes passes with e.g. -XX:+UseZGC -XX:+ZGenerational - Commit

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v16]

2024-04-16 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Integrated: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

2024-04-16 Thread Kevin Walls
On Tue, 9 Apr 2024 11:08:31 GMT, Kevin Walls wrote: > This test incorrectly fails, although rarely, thinking its "thread 2" has > deadlocked. > A change of sleep will likely fix this, but there are other issues, so > cleaning up the test a little.

Re: RFR: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock [v2]

2024-04-16 Thread Kevin Walls
On Tue, 16 Apr 2024 09:26:58 GMT, Kevin Walls wrote: >> This test incorrectly fails, although rarely, thinking its "thread 2" has >> deadlocked. >> A change of sleep will likely fix this, but there are other issues, so >> cleaning up the test

Re: RFR: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock [v2]

2024-04-16 Thread Kevin Walls
On Tue, 16 Apr 2024 00:31:10 GMT, Leonid Mesnik wrote: >> Kevin Walls has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock [v2]

2024-04-16 Thread Kevin Walls
o fail). Use the loop > to check for the status change, which is likely what was intended. > > Show the stackframes on all failures. Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brough

Re: RFR: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html [v2]

2024-04-11 Thread Kevin Walls
On Thu, 11 Apr 2024 07:12:20 GMT, Ludvig Janiuk wrote: >> I used "fold -sw 120" and removed trailing whitespaces. > > Ludvig Janiuk has updated the pull request incrementally with three > additional commits since the last revision: > > - prepends > - fold 100 > - Revert "8329774 Break long

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v15]

2024-04-09 Thread Kevin Walls
On Tue, 9 Apr 2024 06:00:21 GMT, David Holmes wrote: > sounds far too general. I would have expected something that was obviously > connected to jcmd and/or the specific jcmd under discussion. I don't expect so many more of these, but EnableVMInspectDCmd looked too specific, I didn't want to

RFR: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

2024-04-09 Thread Kevin Walls
This test incorrectly fails, although rarely, thinking its "thread 2" has deadlocked. A change of sleep will likely fix this, but there are other issues, so cleaning up the test a little. Remove the probe for the ManagementFactory class, to check we are on jdk5 or later. 8-) When sleeping,

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v15]

2024-04-08 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v14]

2024-04-08 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v13]

2024-04-08 Thread Kevin Walls
On Thu, 4 Apr 2024 12:46:26 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not in

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-04-08 Thread Kevin Walls
On Mon, 8 Apr 2024 13:20:03 GMT, Thomas Stuefe wrote: > Thank you for answering our questions. No problem, thanks Thomas and Andrew. 8-) - PR Comment: https://git.openjdk.org/jdk/pull/17655#issuecomment-2043005639

Integrated: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature

2024-04-04 Thread Kevin Walls
On Tue, 27 Feb 2024 10:44:20 GMT, Kevin Walls wrote: > The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). This pull request has now been integrated. Changeset: 6382a129 Author: Kevin W

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v16]

2024-04-04 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits: - Mer

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-04-04 Thread Kevin Walls
On Wed, 27 Mar 2024 05:26:09 GMT, Chris Plummer wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Undo include > > src/hotspot/share/utilities/debug.cpp line 680: > >> 678:

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v11]

2024-04-04 Thread Kevin Walls
On Fri, 29 Mar 2024 04:05:53 GMT, Serguei Spitsyn wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Test more pointer types: compiled method and metadata. > > test/hotspo

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v13]

2024-04-04 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v12]

2024-04-04 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: JDK-8322042: HeapDumper should perform merge on the current thread instead of VMThread [v2]

2024-04-03 Thread Kevin Walls
On Tue, 2 Apr 2024 21:13:33 GMT, Alex Menkov wrote: >> The fix updated HeapDumper to always perform merge on the current thread. >> >> Testing: tier1-5, all HeapDump-related tests >> Covered heap dumping scenarios: >> - `jcmd GC.heap_dump` command; >> -

Re: RFR: JDK-8322042: HeapDumper should perform merge on the current thread instead of VMThread [v2]

2024-04-03 Thread Kevin Walls
On Tue, 2 Apr 2024 21:13:33 GMT, Alex Menkov wrote: >> The fix updated HeapDumper to always perform merge on the current thread. >> >> Testing: tier1-5, all HeapDump-related tests >> Covered heap dumping scenarios: >> - `jcmd GC.heap_dump` command; >> -

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-28 Thread Kevin Walls
On Wed, 27 Mar 2024 18:39:38 GMT, Chris Plummer wrote: > I think we also need to consider the flip side of this argument. Is this > something that some customers might want to always enable, but don't want to > always have UnlockDiagnosticVMOptions enabled. A new command line flag would > be

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-28 Thread Kevin Walls
On Thu, 28 Mar 2024 14:12:08 GMT, Andrew Dinn wrote: >>> It looks like the test only inspects a thread and a java object. Perhaps >>> you could add tests for additional VM objects. Maybe grab a frame PC from a >>> thread stack trace. >> >> Yes - added a couple of metadata tests, and a

Integrated: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use

2024-03-28 Thread Kevin Walls
On Mon, 25 Mar 2024 13:15:48 GMT, Kevin Walls wrote: > Test uses jdk.test.lib.Utils.getFreePort() when launching a new Java command. > Looks like it already recognises "java.rmi.server.ExportException: Port > already in use: " and retries, but there is a long-standin

Re: RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use [v2]

2024-03-28 Thread Kevin Walls
On Mon, 25 Mar 2024 22:46:47 GMT, Kevin Walls wrote: >> Test uses jdk.test.lib.Utils.getFreePort() when launching a new Java >> command. >> Looks like it already recognises "java.rmi.server.ExportException: Port >> already in use: " and retries,

Integrated: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails

2024-03-28 Thread Kevin Walls
On Tue, 19 Mar 2024 16:23:27 GMT, Kevin Walls wrote: > Client.java has a fixed 30-second timeout on the CountDownLatch to wait for > 10 notifications. > > If it fails, you can't tell if CountDownLatch.await threw, or returned false > and the app threw InterruptedException,

Re: RFR: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails

2024-03-28 Thread Kevin Walls
On Tue, 19 Mar 2024 16:23:27 GMT, Kevin Walls wrote: > Client.java has a fixed 30-second timeout on the CountDownLatch to wait for > 10 notifications. > > If it fails, you can't tell if CountDownLatch.await threw, or returned false > and the app threw InterruptedException,

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-27 Thread Kevin Walls
On Wed, 27 Mar 2024 05:44:25 GMT, Chris Plummer wrote: > It looks like the test only inspects a thread and a java object. Perhaps you > could add tests for additional VM objects. Maybe grab a frame PC from a > thread stack trace. Yes - added a couple of metadata tests, and a compiled method

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v11]

2024-03-27 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v10]

2024-03-27 Thread Kevin Walls
On Wed, 27 Mar 2024 12:23:50 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not in

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v10]

2024-03-27 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v8]

2024-03-26 Thread Kevin Walls
On Tue, 26 Mar 2024 20:52:30 GMT, Serguei Spitsyn wrote: >> Kevin Walls has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request cont

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-26 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v15]

2024-03-26 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - Merge

Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information [v8]

2024-03-26 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose custom

Re: RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use [v2]

2024-03-25 Thread Kevin Walls
something to clarify which test(s) failed, and correct a comment in > test2 of AbstractFilePermissionTest.java Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: show exit code - Changes: - all: https://git.openjdk.org/jdk/pull/18470/files

Re: RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use

2024-03-25 Thread Kevin Walls
On Mon, 25 Mar 2024 19:00:37 GMT, Chris Plummer wrote: >> Test uses jdk.test.lib.Utils.getFreePort() when launching a new Java >> command. >> Looks like it already recognises "java.rmi.server.ExportException: Port >> already in use: " and retries, but there is a long-standing typo in the >>

RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use

2024-03-25 Thread Kevin Walls
Test uses jdk.test.lib.Utils.getFreePort() when launching a new Java command. Looks like it already recognises "java.rmi.server.ExportException: Port already in use: " and retries, but there is a long-standing typo in the check. e.g. test output: Error: Exception thrown by the agent:

RFR: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use

2024-03-25 Thread Kevin Walls
Test uses jdk.test.lib.Utils.getFreePort() when launching a new Java command. Looks like it already recognises "java.rmi.server.ExportException: Port already in use: " and retries, but there is a long-standing typo in the check. e.g. test output: Error: Exception thrown by the agent:

Re: RFR: 8327864: Support segmented heap dump for HotSpotDiagnosticMXBean

2024-03-25 Thread Kevin Walls
On Tue, 12 Mar 2024 07:59:12 GMT, Yi Yang wrote: > We've received feedback from users of cloud APM platform wanting the new > version of the JDK to allow the HotSpotDiagnosticMXBean.dumpHeap > underpinnings to reduce STW time using sgemented heapdump. Supporting > segmented heapdump for

Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information [v7]

2024-03-22 Thread Kevin Walls
On Tue, 5 Mar 2024 11:31:13 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.debug" to implement access to a useful set of the >> established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...". >> >> Not recommended for live prod

Re: RFR: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails

2024-03-21 Thread Kevin Walls
On Tue, 19 Mar 2024 16:23:27 GMT, Kevin Walls wrote: > Client.java has a fixed 30-second timeout on the CountDownLatch to wait for > 10 notifications. > > If it fails, you can't tell if CountDownLatch.await threw, or returned false > and the app threw InterruptedException,

RE: RFD: Remove Hotspot-internal MBeans from sun.management

2024-03-20 Thread Kevin Walls
provides thread count and thread CPU usage by “internal” threads, although the definition of that is maybe unclear. Thanks Kevin From: Kevin Walls Sent: 20 March 2024 10:53 To: Mandy Chung ; Eirik Bjørsnøs ; serviceability-dev@openjdk.org Cc: Volker Simonis ; Alan Bateman Subject: RE: RFD

RE: RFD: Remove Hotspot-internal MBeans from sun.management

2024-03-20 Thread Kevin Walls
: 19 March 2024 16:48 To: Eirik Bjørsnøs ; serviceability-dev@openjdk.org Cc: Volker Simonis ; Kevin Walls ; Alan Bateman Subject: Re: RFD: Remove Hotspot-internal MBeans from sun.management Would a PR to remove these APIs be welcome? Good with me. Mandy On 3/19/24 9:41 AM, Eirik Bjørsnøs wrote

Re: RFR: 8328341: Remove deprecated per-thread compiler stats in sun.management

2024-03-19 Thread Kevin Walls
On Mon, 18 Mar 2024 09:42:13 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes per-thread compiler stats from > `sun.management` > > This removes: > > * The deprecated interface method > `HotspotCompilationMBean.getCompilerThreadStats()` along with the >

RE: [External] : Re: RFD: Can we remove per-thread compiler stats now?

2024-03-18 Thread Kevin Walls
Would that be okay with you? Absolutely!

RE: [External] : Re: RFD: Can we remove per-thread compiler stats now?

2024-03-18 Thread Kevin Walls
snøs Sent: 17 March 2024 18:43 To: Kevin Walls Cc: serviceability-dev@openjdk.org Subject: [External] : Re: RFD: Can we remove per-thread compiler stats now? On Fri, Mar 15, 2024 at 7:54 PM Kevin Walls mailto:kevin.wa...@oracle.com>> wrote: https://openjdk.org/jeps/277 "An API element

RE: RFD: Can we remove per-thread compiler stats now?

2024-03-15 Thread Kevin Walls
Hi, Sounds like a good plan. I don't think it causes any problems, we aren't creating them now. These counters are in jdk8u. The jcmd "jcmd PID PerfCounter.print" shows them when attaching to a JDK8 process. But if nothing relies on them being there… https://openjdk.org/jeps/277 "An API

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v14]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Missing code doc nit. -

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v13]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Missing code doc nit. -

Re: RFR: 8328135: javax/management/remote/mandatory/loading/MissingClassTest.java fails on libgraal

2024-03-14 Thread Kevin Walls
On Thu, 14 Mar 2024 10:46:10 GMT, Doug Simon wrote: > This PR increases a timeout in `MissingClassTest.java` to handle slight > slower compilation on a fastdebug build when using `-Xcomp`. > Testing on mach5 shows that the increase from 60 s to 90 s resolves the > timeouts. Here we are again.

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-14 Thread Kevin Walls
On Mon, 11 Mar 2024 15:19:08 GMT, Daniel Fuchs wrote: >>> Is there any value in keeping `SubjectDelegationPermission` after this >>> change? If so, I would mark that API deprecated for removal, so that it can >>> be removed in the next release or two. >> >> No, nothing uses

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v12]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: RMIConnectionImpl_Stub also should

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v11]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with two additional commits since the last revision: - Clarify JMXConnector equivalenc

  1   2   3   4   5   6   >