On Fri, 4 Aug 2023 22:41:43 GMT, Chris Plummer wrote:
> Normally we want the test args passed to the SA debuggee. In fact for proper
> SA test coverage, it is more important for the test args to be passed to the
> debuggee than to be passed to the test or the the SA tool that the test
>
Normally we want the test args passed to the SA debuggee. In fact for proper SA
test coverage, it is more important for the test args to be passed to the
debuggee than to be passed to the test or the the SA tool that the test
launches. For a couple of jhsdb tests that launch jshell as the
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Fri, 4 Aug 2023 18:34:52 GMT, Chris Plummer wrote:
>> There is coding e.g. in
>> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
>> that deals with shared lib naming on different OS.
>> This code should be simplified.
>
>
On Fri, 4 Aug 2023 19:45:56 GMT, Leonid Mesnik wrote:
>> The fix adds posting VmObjectAlloc events by
>> Unsafe.allocateInstance(Class cls). The previous attempt to post event
>> directly from 'LibraryCallKit::inline_unsafe_allocate()' cause performance
>> regression even if jvmti event is
On Fri, 4 Aug 2023 19:27:50 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/unsafe.cpp line 111:
>>
>>> 109: }
>>> 110:
>>> 111: static inline int field_offset_from_byte_offset(int byte_offset) {
>>
>> Nit: I wonder if the same fix is needed for the previous function at line
>> 107
> The fix adds posting VmObjectAlloc events by Unsafe.allocateInstance(Class
> cls). The previous attempt to post event directly from
> 'LibraryCallKit::inline_unsafe_allocate()' cause performance regression even
> if jvmti event is not enabled. Some optimizations have been disabled just
>
On Fri, 4 Aug 2023 18:10:30 GMT, Serguei Spitsyn wrote:
>> This patch fixes Wconversion in code in the src/hotspot/share/prims
>> directory. Most of the changes correct the types. jfieldID's are created
>> with the int offset returned by InstanceKlass::field_offset().
>> int
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Fri, 4 Aug 2023 09:59:41 GMT, Matthias Baesken wrote:
> There is coding e.g. in
> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
> that deals with shared lib naming on different OS.
> This code should be simplified.
Changes
On Thu, 3 Aug 2023 15:59:14 GMT, Chris Plummer wrote:
>> @ashu-mehra thanks for doing the additional testing. Pity there is no
>> regression/functional test for this.
>
>> @dholmes-ora @plummercj I have improved [dumpclass
>>
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Fri, 4 Aug 2023 16:31:28 GMT, Kevin Walls wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> new can_parallel_dump
>
> test/hotspot/jtreg/serviceability/dcmd/gc/HeapDumpParallelTest.java line 59:
>
>> 57:
On Fri, 4 Aug 2023 13:04:28 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all
This patch fixes Wconversion in code in the src/hotspot/share/prims directory.
Most of the changes correct the types. jfieldID's are created with the int
offset returned by InstanceKlass::field_offset().
int field_offset (int index) const { return
field(index).offset(); }
So
> ### Motivation and proposal
> Hi, heap dump brings about pauses for application's execution(STW), this is a
> well-known pain. JDK-8252842 have added parallel support to heapdump in an
> attempt to alleviate this issue. However, all concurrent threads
> competitively write heap data to the
On Wed, 2 Aug 2023 14:33:28 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all
There is coding e.g. in
https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
that deals with shared lib naming on different OS.
This code should be simplified.
-
Commit messages:
- JDK-8313670
Changes:
On Wed, 14 Jun 2023 01:02:09 GMT, Alex Menkov wrote:
> If virtual thread has frames in stackChunks, need to apply load barriers
> before processing nmethods (javaVFrame::locals() and
> javaVFrame::expressions() do it internally)
>
> Testing: tier1-tier5;
> 400 runs of VThreadStackRefTest.java
> The fix adds posting VmObjectAlloc events by Unsafe.allocateInstance(Class
> cls). The previous attempt to post event directly from
> 'LibraryCallKit::inline_unsafe_allocate()' cause performance regression even
> if jvmti event is not enabled. Some optimizations have been disabled just
>
On Thu, 3 Aug 2023 23:39:11 GMT, Andrew John Hughes wrote:
> Removing it to hardcode a format thus seems like a bit of a backward step to
> me.
But we only defined abstract things like `SIZE_FORMAT` because there was no
single specifier accepted by all C runtimes and which behaves in the same
28 matches
Mail list logo
