I agree not to close the old PRs without right reason.
As your suggestion, reviewing it is the way to colse it.
Thanks.
---Original---
From: "Hyukjin Kwon"
Date: 2017/7/26 12:15:45
To: "??"<1427357...@qq.com>;
Cc: "user @spark";
Subject:
That's waiting for a review as seen. There have been few discussions about
this. I am personally against closing only because it is old.
I have made periodically PRs to close other inactive PRs (e.g., not
responsive to review comments or Jenkins failures).
So, I guess most of such PRs are
Hi all,
I find some PR were created one year ago, the last comment is several monthes
before.
No one to close or reject it.
Such as 6880, just put it like this?
---Original---
From: "Hyukjin Kwon"
Date: 2017/7/25 09:25:28
To: "??"<1427357...@qq.com>;
Cc: "user
I think that's described in the link I used - http://spark.apache.org/
contributing.html.
On 25 Jul 2017 10:22 am, "萝卜丝炒饭" <1427357...@qq.com> wrote:
Another issue about contribution.
After a pull request is created, what should creator do next please?
Who will close it please?
---Original---
Another issue about contribution.
After a pull request is created, what should creator do next please?
Who will close it please?
---Original---
From: "Hyukjin Kwon"
Date: 2017/7/25 09:15:49
To: "Marcelo Vanzin";
Cc:
I see. In any event, it sounds not required to work on an issue -
http://spark.apache.org/contributing.html .
"... There is no need to be the Assignee of the JIRA to work on it, though
you are welcome to comment that you have begun work.."
and I was just wondering out of my curiosity. It should
Hi vanzin, kwon,
thanks for your help.
---Original---
From: "Hyukjin Kwon"
Date: 2017/7/25 09:04:44
To: "Marcelo Vanzin";
Cc: "user";"??"<1427357...@qq.com>;
Subject: Re: how to set the assignee in JIRA please?
On Mon, Jul 24, 2017 at 6:04 PM, Hyukjin Kwon wrote:
> However, I see some JIRAs are assigned to someone time to time. Were those
> mistakes or would you mind if I ask when someone is assigned?
I'm not sure if there are any guidelines of when to assign; since
there has been
However, I see some JIRAs are assigned to someone time to time. Were those
mistakes or would you mind if I ask when someone is assigned?
When I started to contribute to Spark few years ago, I was confused by this
and I am pretty sure some guys are still confused.
I do usually say something like
We don't generally set assignees. Submit a PR on github and the PR
will be linked on JIRA; if your PR is submitted, then the bug is
assigned to you.
On Mon, Jul 24, 2017 at 5:57 PM, 萝卜丝炒饭 <1427357...@qq.com> wrote:
> Hi all,
> If I want to do some work about an issue registed in JIRA, how to set
10 matches
Mail list logo