Hi,
Please review the latest update, I think this should address the issues
raised,
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/2/webrev/
- revert the clone method changes so that return type remains Object
- break long lines
- fix fallthrough warnings as Andrew suggested.
Cheers,
Henry
On 02/20/2014 10:09 AM, Phil Race wrote:
On 2/20/2014 12:05 AM, Henry Jen wrote:
On 02/19/2014 02:59 PM, Henry Jen wrote:
On 02/19/2014 01:46 PM, Phil Race wrote:
W.r.t the following change ...
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java.sdiff.html
145 class Htable implements Cloneable {
...
<208 protected Object clone() {
208 protected Htable clone()
---------
exactly what warning is this suppressing ?
This eliminate "unchecked" cast warning when calling this method to get
an instance with correct class type.
That's not exactly correct, it just eliminate the need to cast, not
warning.
Would you advice to revert them or keep it?
In that case, I'd suggest to revert them
-phil.
