On 03/06/2015 03:21 PM, Laurent Bourgès wrote:
Phil,
> Two more things regarding the test
> 1. It was pointed out that you are using GPL+CP .. tests just use GPL
You mean I must fix the test file header ?
Yes, please.
> 2. There's no @bug tag the test. In fact there's no bug ID here at
all :-)
>
> A bug ID is needed in order to push.
> You have a JBS account now so could have created it yourself .. but
> by the time I remembered that I'd already created it for you :-
>https://bugs.openjdk.java.net/browse/JDK-8074587
<https://bugs.openjdk.java.net/browse/JDK-8074587>
>
> But I did assign it to you :-)
You're right, I got it.
It seems it is not affected to the graphics rasterizer project, isn't it ?
You can push to graphics rasterizer of course, and no bug ID is needed.
But I assume this to be one that we'd want to push sooner rather than later
to the JDK 9 client forest here :-
http://hg.openjdk.java.net/jdk9/client/jdk
since its not directly related to marlin
I am still not familiar with JBS nor pushing changes...
I will read again the doc about pushing changesets ... tomorrow as it
is late. Could you give some hints ?
Jim or I will have to push it there (jdk9/client) for you of course, but
the more such
fixes you contribute, the sooner we can ask for JDK 9 committer rights
as well.
Do you need another webrev with the correct bug id ?
Yes, in order to push it for you, but I'd suggest to hold off to see if
Jim points
out anything first ..
-phil.
Thanks,
Laurent
