Looks ok to me.

Regards
Prasanta
On 11/23/2015 5:31 PM, Jayathirth D V wrote:

Hi Prasanta,

Removed repeated usage of getWidth() and getHeight(). Please review.

http://cr.openjdk.java.net/~jdv/8041501/webrev.02/ <http://cr.openjdk.java.net/%7Ejdv/8041501/webrev.02/>

Thanks,

Jay

*From:*prasanta sadhukhan
*Sent:* Monday, November 23, 2015 5:15 PM
*To:* Jayathirth D V
*Cc:* Philip Race; 2d-dev@openjdk.java.net
*Subject:* Re: <OpenJDK 2D-Dev> Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

On 11/23/2015 5:11 PM, Jayathirth D V wrote:

    Hi Prasanta,

    Thanks for suggestion. I have made related changes and updated the
    Webrev.

    Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/
    <http://cr.openjdk.java.net/%7Ejdv/8041501/webrev.01/>

    Please review.

There's no point getting the width & height repeatedly . You can get it once and use that info in the loop. It's not going to change in runtime, isn;t it :-)

Regards
Prasanta

    Thanks,

    Jay

    *From:*prasanta sadhukhan
    *Sent:* Monday, November 23, 2015 4:43 PM
    *To:* Jayathirth D V; 2d-dev@openjdk.java.net
    <mailto:2d-dev@openjdk.java.net>
    *Cc:* Philip Race
    *Subject:* Re: <OpenJDK 2D-Dev> Review request for JDK - 8041501 :
    ImageIO reader is not capable of reading JPEGs without JFIF header

    Looks ok to me.
    But probably you could check for image width &height
    programmatically instead of hardcoding to 64 in testcode.

    Regards
    Prasanta

    On 11/23/2015 4:09 PM, Jayathirth D V wrote:

        Hello All,

        _Please review following fix in JDK9:_

        Bug : https://bugs.openjdk.java.net/browse/JDK-8041501

        Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.00/
        <http://cr.openjdk.java.net/%7Ejdv/8041501/webrev.00/>

        Issue : Pink discoloration when we read JPEG images without
        JFIF & EXIF header and having no subsampling.

        Root cause : We are overriding JPEG color space set in IJG
        library at imageioJPEG.c without checking component ID’s
        properly when JFIF & EXIF are not there. Decision to change
        color space is solely done consulting sampling factors.

        Solution : Added extra check to verify component ID’s also
        before changing color space determined by IJG library when
        there is no JFIF & EXIF header.

        Thanks,

        Jay


Reply via email to