Theoretically we've been going to fix this fragile test for weeks.

It tests something important or else I'd ditch it completely ..

Prasanta  ?

-phil.

On 10/30/19, 7:14 AM, Langer, Christoph wrote:

Hi Matthias,

looks good, I definitely second that. Let's wait what 2d folks (Phil?) have to say.

Best regards

Christoph

*From:* Baesken, Matthias <matthias.baes...@sap.com>
*Sent:* Mittwoch, 30. Oktober 2019 14:59
*To:* 2d-dev@openjdk.java.net
*Cc:* Langer, Christoph <christoph.lan...@sap.com>
*Subject:* RFR [XS] : 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java

Please review the following small change .

It excludes javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java ; the test seems to be fragile on various Linux distros ,

    for instance on our Ubuntu 18 .

The issues are already described in detail  here :

https://bugs.openjdk.java.net/browse/JDK-8229935

"All in all this test looks really fragile. It is a miracle it has passed as much as it has .. I think Linux may expose this because the font being used is more or less "fixed" on the other platforms but
on Linux the font being used varies."

As long as 8229935 is notfixed, the test should be excluded at least on Linux .

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8233202

http://cr.openjdk.java.net/~mbaesken/webrevs/8233202.0/ <http://cr.openjdk.java.net/%7Embaesken/webrevs/8233202.0/>

Thanks, Matthias

Reply via email to