I'll push this now as XS with the review of Christoph. I think Prasanta and Phil are okay with the change too .
Best regards, Matthias From: Baesken, Matthias Sent: Donnerstag, 31. Oktober 2019 09:51 To: 'Prasanta Sadhukhan' <prasanta.sadhuk...@oracle.com> Cc: 2d-dev@openjdk.java.net; Philip Race <philip.r...@oracle.com>; Langer, Christoph <christoph.lan...@sap.com> Subject: RE: [OpenJDK 2D-Dev] RFR [XS] : 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java * We can work on it but probably, it is safe to problem list the test for linux for now. Ok, great. May I add you as reviewer ? Best regards, Matthias From: Prasanta Sadhukhan <prasanta.sadhuk...@oracle.com<mailto:prasanta.sadhuk...@oracle.com>> Sent: Donnerstag, 31. Oktober 2019 09:27 To: Philip Race <philip.r...@oracle.com<mailto:philip.r...@oracle.com>>; Langer, Christoph <christoph.lan...@sap.com<mailto:christoph.lan...@sap.com>> Cc: Baesken, Matthias <matthias.baes...@sap.com<mailto:matthias.baes...@sap.com>>; 2d-dev@openjdk.java.net<mailto:2d-dev@openjdk.java.net> Subject: Re: [OpenJDK 2D-Dev] RFR [XS] : 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java This test tests the newly added public API of BasicGraphicsUtils (exposing the functionality provided by internal class SwingUtilities2) for use by third party LAFs in JDK9 and beyond, so I guess we cannot ditch it completely. Regarding the test fragility, I actually incorporated the changes proposed by Phil, which are - add "x" to the position it passes to checkImageContainsSymbol - increase WIDTH - use rendering hints to use aliased text in testDrawString() which makes the test pass in linux but it now creates problem in macos. We can work on it but probably, it is safe to problem list the test for linux for now. Regards Prasanta On 30-Oct-19 8:08 PM, Philip Race wrote: Theoretically we've been going to fix this fragile test for weeks. It tests something important or else I'd ditch it completely .. Prasanta ? -phil. On 10/30/19, 7:14 AM, Langer, Christoph wrote: Hi Matthias, looks good, I definitely second that. Let's wait what 2d folks (Phil?) have to say. Best regards Christoph From: Baesken, Matthias <matthias.baes...@sap.com><mailto:matthias.baes...@sap.com> Sent: Mittwoch, 30. Oktober 2019 14:59 To: 2d-dev@openjdk.java.net<mailto:2d-dev@openjdk.java.net> Cc: Langer, Christoph <christoph.lan...@sap.com><mailto:christoph.lan...@sap.com> Subject: RFR [XS] : 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java Please review the following small change . It excludes javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java ; the test seems to be fragile on various Linux distros , for instance on our Ubuntu 18 . The issues are already described in detail here : https://bugs.openjdk.java.net/browse/JDK-8229935 "All in all this test looks really fragile. It is a miracle it has passed as much as it has .. I think Linux may expose this because the font being used is more or less "fixed" on the other platforms but on Linux the font being used varies." As long as 8229935 is not fixed, the test should be excluded at least on Linux . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8233202 http://cr.openjdk.java.net/~mbaesken/webrevs/8233202.0/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8233202.0/> Thanks, Matthias
