This is OK. I think a lot of the generics were written at a time which pre-dated
the diamond operator in JDK 7.

using sun.security.action - something in java.base is something we should
clean up some day, but you are just changing the way it is referenced and
it is on my clean up list so OK.

Please do push to jdk/client.

-phil.

On 2/17/20 1:57 AM, Langer, Christoph wrote:

Hi,

I did some cleanups in src/java.desktop/share/classes/sun/font/SunFontManager.java and src/java.desktop/share/classes/sun/font/TrueTypeFont.java which I’d like to contribute.

Most is about indentation, generics initialization and better usage of AccessController::doPrivileged and friends. Also, some unused imports and locals were removed/commented out.

Please review 😊

Bug: https://bugs.openjdk.java.net/browse/JDK-8239149 <https://bugs.openjdk.java.net/browse/JDK-8239149>

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8239149.0/ <http://cr.openjdk.java.net/~clanger/webrevs/8239149.0/>

Best regards

Christoph


Reply via email to