Hi Phil, thanks for the review. I pushed to jdk-client: http://hg.openjdk.java.net/jdk/client/rev/5cc32ff976fe
Best regards Christoph From: Phil Race <[email protected]> Sent: Dienstag, 25. Februar 2020 00:49 To: Langer, Christoph <[email protected]>; [email protected] Subject: Re: [OpenJDK 2D-Dev] RFR 8239149: Cleanups in SunFontManager.java and TrueTypeFont.java This is OK. I think a lot of the generics were written at a time which pre-dated the diamond operator in JDK 7. using sun.security.action - something in java.base is something we should clean up some day, but you are just changing the way it is referenced and it is on my clean up list so OK. Please do push to jdk/client. -phil. On 2/17/20 1:57 AM, Langer, Christoph wrote: Hi, I did some cleanups in src/java.desktop/share/classes/sun/font/SunFontManager.java and src/java.desktop/share/classes/sun/font/TrueTypeFont.java which Iād like to contribute. Most is about indentation, generics initialization and better usage of AccessController::doPrivileged and friends. Also, some unused imports and locals were removed/commented out. Please review š Bug: https://bugs.openjdk.java.net/browse/JDK-8239149 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8239149.0/ Best regards Christoph
