On Mon, 2 Nov 2020 04:19:57 GMT, Phil Race <p...@openjdk.org> wrote:

> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an 
> OpenType text shaping library
> 
> https://bugs.openjdk.java.net/browse/JDK-8247872
> 
> This has passed building and headless and headful automated tests on all 
> platforms.

Build changes look good.

I'm just a bit curious about the added, empty, 
`src/java.desktop/share/native/libharfbuzz/abc.txt`...

If it really is in upstream source, I'm not saying you should remove it. It 
just looks very odd. It's not a merge artifact?

(I could not even add review comments to an empty file in github!  😮)

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/993

Reply via email to