On Thu, 5 Nov 2020 13:36:18 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Looks like the build on macOS via GitHub will be broken by this fix? > > @mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to > be disabled for clang for Xcode 12 to not complain. I added that to the disabled warnings .. now I suppose the actions will re-run but I don't see any sign of it yet. Just that the results that were there are now gone. A few thoughts on this - github sends so many messages that it is easy to miss the important ones - using the default for github we are at the whim of when ever they switch and if this change had been pushed 6 weeks ago likely it would have passed until the day github upgraded. - it also means passing a github build does not guarantee it will pass on the "official" toolchains. ------------- PR: https://git.openjdk.java.net/jdk/pull/993