On Tue, 16 Mar 2021 19:46:16 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>>> If it is a complete "General" loop which supports all possible combination >>> of incoming src/comp/dst/transform/etc I suggest to confirm that in the >>> test. >> >> @mrserb This code is currently only used by GlyphListLoopPipe-based text >> renderers (SolidTextRenderer, AATextRenderer, LCDTextRenderer), so it won't >> be invoked for arbitrary composites and paint types. But different >> destination types (image formats) and transforms are supported. >> >> What kind of test are you having in mind? I can extend the added >> MacEmoji.java test, that will check that 'something' is painted to different >> types of BufferedImage-s and/or with transforms applied. Or you want me to >> add a manual test case? > >> What kind of test are you having in mind? I can extend the added >> MacEmoji.java test, that will check that 'something' is painted to different >> types of BufferedImage-s and/or with transforms applied. Or you want me to >> add a manual test case? > > The automated tests will be enough, not sure about 'something is painted' > however, it is better to check that it works. @mrserb I don't know how to check automatically that glyph painting works correctly. Could you please suggest a way to do it? In JetBrains Runtime we have a test that checks that rendered emoji glyph matches one of stored 'golden images', but I don't think that's suitable for OpenJDK, unless someone will volunteer to update that list when the need arises (e.g. when newer version of macOS changes the font, or rendering details). At the moment, we have already 7 golden images for a single glyph in our repository. ------------- PR: https://git.openjdk.java.net/jdk/pull/3007
