On Thu, 18 Mar 2021 10:02:11 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> @mrserb I don't know how to check automatically that glyph painting works >> correctly. Could you please suggest a way to do it? In JetBrains Runtime we >> have a test that checks that rendered emoji glyph matches one of stored >> 'golden images', but I don't think that's suitable for OpenJDK, unless >> someone will volunteer to update that list when the need arises (e.g. when >> newer version of macOS changes the font, or rendering details). At the >> moment, we have already 7 golden images for a single glyph in our repository. > > You the current image from the MacEmoji test as a golden image for other > formats/transforms/extraalpha/etc. For example, if DST type is changed then > it is unlikely the shape of the emoji will be changed as well, or if it is > too big/ too small. > > BTW It will be good if the test will fail on the current metal implementation. Implementation for Metal pipeline has been added. I've also updated the test case to check rendering into different types of images, including VolatileImage. The test will fail now, if corresponding OpenGL (or Metal, if it's explicitly enabled) implementation part would be rolled back. ------------- PR: https://git.openjdk.java.net/jdk/pull/3007
