-----Original Message----- From: Ace <ace-boun...@ietf.org> On Behalf Of Marco Tiloca Sent: Wednesday, January 8, 2020 8:08 AM To: Jim Schaad <i...@augustcellars.com>; draft-tiloca-ace-oscore-gm-ad...@ietf.org Cc: ace@ietf.org Subject: Re: [Ace] remarks on draft-tiloca-ace-oscore-gm-admin-00
Hi Jim, Thanks a lot for this review! We have been working on an updated version accessible at [1], which is already taking into account your comments on CoRAL. Please, find below inline some more replies and open points. Best, /Marco [1] https://gitlab.com/crimson84/draft-tiloca-ace-oscore-gm-admin/blob/v-01/draft-tiloca-ace-oscore-gm-admin.md On 2019-11-20 00:13, Jim Schaad wrote: > This is just going to be a high level review on how things are done > rather than a detailed review on each line of text. > > 1. - Go and read that CoRE Pub-Sub update document - you know the one > that Klaus and friends have not managed to get written since the model > proposal was done way back when. <MT> Yes, we are now relying on an akin interface, along the lines of the now published draft https://datatracker.ietf.org/doc/draft-hartke-t2trg-coral-pubsub/ </MT> > > 2. Re-write this to use CoRAL - Yes I know that this makes another > dependency on getting it published from the CoRE group, but I don't > want to do things multiple times. <MT> We have now also added examples in CoRAL, for all the interactions between Administrator and Group Manager, now also extended with FETCH for filtered retrieval. </MT> > > 3. I think that this document really needs to be able to be used with > HTTP/JSON as well as CoAP. If you can get the JSON version of CoRAL from > Klaus then this falls out without any work. <MT> We are now saying the CoRAL examples are in text format, but they are in CBOR or JSON on the wire, with no particular additional effort. Is this enough? </MT> Sounds good. > > 4. Are you making it a requirement that the group name be the same as > the group identifier assigned by the "group_name" parameter? If so > then having some type of title and description would seem to be almost > mandatory. <MT> They are in fact the very same thing. The "group_name" parameter specifies the group name, as intended to identify the OSCORE group both by the administrator and the joining nodes in the other related documents. We can use only "invariant name" rather than "invariant identifier". Are we missing something? If so, what do you suggest we should give a title and description to? </MT> If you are looking at "group_name":"GP00123", then as a configuration agent it is difficult to know just what this group is supposed to be. In this case some type of title or description helps to figure that out. > > 5. There needs to be some parameters around pointing to the correct > AS and so forth. The management API may reject because it does not trust the > AS. > Don't assume that this is a single value for the AS either. <MT> This is good and also aligned with other related drafts. If we interpret your suggestion correctly: 1) The POST request to /manage may specify also an optional 'as_uri' parameter, with the link to a suggested AS. The GM may accept the suggestion or not. If not, it has to think of an alternative AS, as valid issuer of tokens for joining that group. 2) The GM must have one more parameter in the group configuration with the effective AS URI, i.e. either one provided by the administrator and accepted, or one otherwise decided. Do you think of any additional related parameters to be included in the POST request, other than 'as_uri'? Perhaps the public key of the suggested AS if applicable? Do you think the suggestion in the request should actually be a list of AS, out of which the GM may pick up at most one? </MT> I have put something into draft-schaad-core-reef which starts thinking about this. I think that we need to sit down and do a brainstorming session to figure out what items should/should not be put into such a structure. > > 6. You are missing a lot of management detail on the POST to the > group node. Some of the things that are missing would be: > a) Is the group active or inactive <MT> We can have one more parameter on the group-configuration resource for this. We are interpreting active/inactive as follows. Ideally, upon creating the group, the request can specify the initial status as active or inactive. Upon later updating the group by sending a request to the group-configuration resource, the administrator can change the status (or read it through a GET). Then the active/inactive status has two parallel scopes: 1) one scope is for the GM alone, i.e the GM would allow the joining of new group members only if the group is set as active. 2) when the group is set as inactive, the current group members should refrain from sending and should not expect receiving any message protected with that group key material. However, there is no way to actually force them to. In support to scope (2), when the status changes to inactive, the GM should inform group members about that. To this end, the group-membership resource intended for group members would also include a parameter reflecting the group status and aligned in value with the one in the group-configuration resource. Then, there are two ways to inform the group members of a status change. a) A way is to have the group members observing the group-membership resource (that they may have been doing already anyway for notification-based rekeying). b) A second way is for the group members to have a dedicated local resources for this (and other) kind of control communication (e.g. rekeying). This is something we are also considering in ace-key-groupcomm(-oscore) for receiving individual rekeying messages. In either case this would require either: i) each node to provide the GM with the URI to such local resource, in the join request; or ii) the GM to include in the join response to each joining node a same multicast address targeting a local resource that that node has to create to receive control messages. </MT> I don't remember for sure what I was thinking about when I wrote this. I think that I was more interested in if one can or cannot join a group when it is inactive and what happens. If you set a group to inactive, are all members of the group removed or does the group just stop issuing new keys? > b) How does the server react if you change a the content encryption > algorithm, is this a simple re-key operation or is it more complicated <MT> An easy answer would be rekeying the group, just as for any other triggering reason. I agree this should be mention in this draft. However, I think a more elaborated description of what happens if the algorithm is changed (regardless why and how) should be actually better given in oscore-groupcomm (the what) and in ace-key-groupcomm-oscore (the how). </MT> Punting to a different document is fine as long as it really is there. However, this is the place where it appears to be changed by an external source and thus seems to be a good place to talk about it. > c) How does the server react if you change the signature algorithm? > This would seem to be a much harder thing to do if the group is not > empty or not active as everybody is going to need to re-join. <MT> Right. If the signature algorithm changes, the current public keys may be not compatible with it any longer. We see the following possible ways, assuming the current group members have learnt of the new algorithm in use. 1) The hard way, i.e. everyone leaving and re-joining. 2) A more lightweight way, i.e. relying on yet another operation for current group members on the GM, to upload a new public key consistent with the new algorithm. This would require to proof possession of the corresponding private key, as it is done upon joining. Probably, in this case, this can happen like we do in the Group OSCORE profile of ACE between the Client and the AS, see the bullet point on 'client_cred_verify' at [2]. And again it looks like details on the way this is done fits better in other documents. [2] https://tools.ietf.org/html/draft-tiloca-ace-group-oscore-profile-01#section-3.1 </MT> See comment above. > d) Other parameter that are changed may be just as bad as changing the > signature algorithm - how the re-key is done jumps immediately to mind. <MT> Yes, changing HKDF/Alg results in what discussed two replies above; changing anything else (thus related to signatures) results in what discussed in the reply above. </MT> Much of this may go to say that changing this parameters kicks everybody off the group and restarts from scratch. > > 7. Is there currently any way for a KDC to signal to all of the > members that have joined that the key group no longer exists? A > DELETE would seem to indicate the need to be able to do this. <MT> Right, the DELETE of a group-configuration resource would trigger something like this. The current resource maintaining on the GM consists in: destroying both group-configuration and group-membership resource, then reply to the Administrator. That said, a possible extension to also inform current group members is akin to what we describe above about signaling that the group has moved to inactive state. That is: i) if group members observe the group-membership resource, a 4.04 notification is sent to them, upon deleting that resource. ii) if group members have their own local resource to receive control messages from the GM, a control message can inform about the deletion of such group-membership resource. This would be particularly convenient to be sent over multicast. This method (ii) would actually require the GM to send these messages to the group members first, and only afterwards actually delete the group-membership resource, in case information such as the destination addresses and URIs to consider are stored as part of the group-membership resource itself. A group member can of course discover what happened at any time, just by sending any type of request to the deleted group-membership resource and getting a 4.04 response back. The actual difference between an existing inactive group and a deleted group is that the latter has no way back, and would need to be re-created from scratch on the GM by the Administrator. </MT> Also could say that you can only delete a successfully inactivated group. Jim > > Jim > > > -- Marco Tiloca Ph.D., Senior Researcher RISE Research Institutes of Sweden Division ICT Isafjordsgatan 22 / Kistagången 16 SE-164 40 Kista (Sweden) Phone: +46 (0)70 60 46 501 https://www.ri.se _______________________________________________ Ace mailing list Ace@ietf.org https://www.ietf.org/mailman/listinfo/ace
