http://bugzilla.kernel.org/show_bug.cgi?id=6892





------- Comment #16 from [EMAIL PROTECTED]  2007-10-23 23:01 -------
>Re: PM should have a generic policy ... that's what the current wakeup bits do;
There is one thing that I concern about.
When the wakeup bit is set, ACPI enables the wakeup GPE, so that PME can
wakeup the device at runtime, but it can also wakeup the system when the
system is in sleep state.
If a user want to enable the runtime wakeup support, he may find that the
system may wakeup when it's in sleep state which is not expected,
so this is a regression. And that's why David's patch was dropped from -mm
tree.
IMO, runtime wakeup and system sleep wakeup are semantically different while
they are controlled be the same flag in Linux.
If we have a look at the Windows device manager, we can see that two config
options are available for a wakeup-aware device:
1."Allow the computer to turn off this device to save power"
2."Allow this device to bring the conputer out of standby"
Apparently they stand for runtime wakeup and system sleep wakeup. So I'm
wondering if we need another wakeup flag for the system sleep wakeup control.

>The ACPI GPE based PME is a little complex, so need some time.
>But first we need pci_enable_wake hook into ACPI to enable GPE.
>David, I thought you have a patch for this, can you repost to the list and get 
>it merged?

In the ACPI GPE based PME case, drivers should call pci_enable_wake once the
wakeup bit is set, and the corresponding ACPI platform hook should enable the
wakeup GPE as a result rather than only setting the wakeup flags for the
corresponding ACPI device.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to