http://bugzilla.kernel.org/show_bug.cgi?id=11549
------- Comment #6 from [EMAIL PROTECTED] 2008-09-17 23:32 ------- [EMAIL PROTECTED] wrote: > I've reviewed your patch and I have two questions. > Q1. do we really need a spin_lock in gpe_transaction? In fact, we don't need > to > disable the irq here, we only want to make sure ec->t can not be accessed by > acpi_ec_gpe_handler and ec_poll at the same time, right? > of course this won't introduce new bugs, but it's overkill. :p fill free to suggest lighter synchronization. > > Q2. the same question (question c) as Yakui listed above. > In this patch, one ec transaction can be done by ec_poll and ec_gpe_handler > together. but this doesn't work for the machines that has "wrong status before > GPE arrives". ec_poll() starts to work only if interrupt-based transaction fails. And interrupt-based transaction code will be started by GPE handler, so will automatically wait for a GPE to check correct status. > In fact, I don't think the ec driver should fit for all ECes, including the > broken ones. there are always some cases that we can not cover, like the one > listed above. > We only need to implement different modes in ec driver just like we did > before, > and for every ec, we can make sure there is at least one mode can work for it. Doesn't work this way. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
