http://bugzilla.kernel.org/show_bug.cgi?id=11549
------- Comment #7 from [EMAIL PROTECTED] 2008-09-17 23:36 -------
Hi Yakui,
I answered all your "issues" several times already, and I am getting tired
to repeat same things over and over.
Please consider filtering your questions with Len or Rui.
Thanks,
Alex.
[EMAIL PROTECTED] wrote:
> Hi, Alexey
> Thanks for the fixing.
> Why not send your patch to ACPI mailing list before it is attached in the
> bugzilla?
> When an issue is raised about your patch, you only fix it. But IMO you
> never consider the side-effect of your change.
> For example: I raise the synchronization issue in the patch of commet #1.
> Then you add the spin_lock protection in the comment #3. In the updated patch
> once the EC I/O data port is accessed, the spin_lock will be used. But if OS
> does 1000 EC transactions per second, it will disable interrupt at least for
> about 1ms.(EC device is connected with LPC bus. The access speed is very
> slow).
> Is it appropriate that the interrupt is disabled for so long time?
>
> The following ugly code still exists. The address of local variable in
> function is assigned to the global pointer variable.
> >struct transaction_data t = {.wdata = wdata, .rdata = rdata,
> .wlen = wdata_len, .rlen = rdata_len};
> >ec->t = &t;
>
> At the same time I raise three issues about your patch. But there is no
> explanation about it.(Two are raised in my email. One is raised in comment #2)
> a. bogus timeout in EC transaction
> b. the EC notification event will be lost in some specific cases
> c. On the laptop of bug 11309 the EC sometimes can't be accessed correctly
> while EC is in polling mode(After EC GPE storm is detected). But in your patch
> when the EC GPE storm is detected, it will also work in polling mode while
> doing EC transaction.
>
> Thanks.
>
>
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
acpi-bugzilla mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
