https://bugzilla.kernel.org/show_bug.cgi?id=43228
Peter <lekenst...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73262|0 |1
is obsolete| |
--- Comment #12 from Peter <lekenst...@gmail.com> 2012-05-16 20:29:37 ---
Created an attachment (id=73316)
--> (https://bugzilla.kernel.org/attachment.cgi?id=73316)
Fix for calling _PS3 for D3cold
Rafael, that was indeed a guess. Before trying to cook another patch I started
understanding what you were exactly trying to achieve with your patch by
looking at the spec and the related subsystems.
Funny enough my idea for a fix was the same as yours, setting the state to '3'
explicitly. Unfortunately, this did not work.
Looking further, this makes sense since there is also a check before the _PSx
method is executed:
if (device->power.states[state].flags.explicit_set) {
explicit_set is 1 if _PSx was detected in acpi_bus_get_power_flags. The
attached patch is tested and fixes this (three lines to satisfy the kernel
coding style).
A quick grep showed that PCI_D3hot is used where "D3" is meant, i.e. "do not
care about D3hot or D3cold, just save power by putting the device off". So yes,
for compatibility reasons, it's probably better to keep the D3hot state as it
for now.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
