https://bugzilla.kernel.org/show_bug.cgi?id=43228
--- Comment #19 from Rafael J. Wysocki <r...@sisk.pl> 2012-05-17 16:09:29 --- (In reply to comment #16) > I see one possibly (unrelated) error: > acpi_bus_update_power first calls acpi_bus_get_power and then tries to > acpi_bus_set_power with the state returned by the getter. > But acpi_bus_get_power calls _PSC which returns at most 3 for D3, it does not > make a distinction between D3hot and D3cold. I don't think this is a big deal at the moment, but we need to fix this. Thanks for spotting it! > On the 258 acpidumps I checked, there is no \_SB._OSC method that could > advertise both D3hot and D3 support, not does it have any _PR3 method as > stated > in table 6-147 of the ACPI Spec v5: > > Field name: _PR3 support > > This bit is set if OSPM supports reading _PR3and using power > > resources to switch power. Note this handshake translates to an > > operating model that the platform and OSPM supports both the power > > model containing both D3hot and D3. > > From sect 2.4 Sleeping State Definitions of the ACPI spec v5: > > The D3hot state differs from the D3 state in two distinct parameters; the > > main power rail is present and software can access a device in D3hot. For > > devices that support both D3hot and D3 exposed to OSPM via _PR3, device > > software/drivers must always assume OSPM will target D3and must > > assume device context will be lost. > Can't we stick to one D3 state then and add a flag for support of D3hot? We might, but for that we'd need to revert some commits that have dependencies on top. Besides, D3hot and D3cold are supposed to be different _states_. My goal for now is to make pci_set_power_state(PCI_D3hot) work as before and we can take care of the other things (like comments printing D4 etc.) later. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
