On Friday 25 January 2013 16:50:08 Marco Martin wrote: > On Friday 25 January 2013, Volker Krause wrote: > > I know that pretty much the same approach works fine in an other project > > which uses Sqlite and PostgreSQL, so both can - in theory - handle > > prepared > > queries. For PostgreSQL it also doesn't seem to be causing issues with > > Akonadi, Till is using it on Mac for example. The special thing about > > Sqlite in Akonadi is the thread safety patches we had to add on top. > > > > So, what I could imagine is an active query object causes a lock to be > > held > > somewhere, which would be released in the dtor. Obviously, anything like > > that breaks with the caching. > > > > Marco's patch looks good to me, definitely the safe place to add this > > check. We'd need to check where the cache is used to see what other > > options we have (keep in mind the auto-generated code!). > > ok, do you think can be pushed? also, where? 1.9? master?
IMHO yes, preferably 1.9 (and merge that into master if you need it there right away too). regards, Volker _______________________________________________ Active mailing list [email protected] https://mail.kde.org/mailman/listinfo/active
