> CLANGXX=${CLANGXX:-$(echo $CLANG | sed -e 's/gcc$/g++/')}
What if there is more than one "gcc" in the compiler path?
Otherwise LGTM.
On Wed, Oct 1, 2014 at 1:35 PM, Yuri Gribov <tetra2...@gmail.com> wrote:
> On Fri, Sep 19, 2014 at 11:13 PM, Yuri Gribov <tetra2...@gmail.com> wrote:
>> Will test and resend on Monday.
>
> Ok, I've fallen ill and then completely forgot about this. Here's an
> updated version.
>
>>> CLANG=${CLANG:-clang}
>> You probably need the same for CLANGXX
>
> I'm doing this below depending on whether CLANG is really clang or gcc.
>
>> Why are you disabling leak detection? It is on by default, which means
>> you are benchmarking not the same thing that users run.
>> At least make it an option.
>
> I've kept the detect_leaks=0 because as kcc mentioned lots of tests
> have leaks. If you desperately want this cluttered stderr you can
> remove the detect_leaks=0 part from final patch (or I can do it
> myself).
>
>> I don't understand this LD_LIBRARY_PATH magic, what's its for?
>
> Fixed. This now allows user to override default script's ASAN_OPTIONS.
>
> @Evgeniy: you can just remove detect_leaks=0 if you desperately want
> this stderr clutter in runner's output.
>
> -Y
>
> --
> You received this message because you are subscribed to the Google Groups
> "address-sanitizer" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to address-sanitizer+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
