On 28/08/12 09:57 +0200, Jiří Stránský wrote:
On 27.8.2012 17:15, Jason Guiditta wrote:
On 24/08/12 11:05 +0200, [email protected] wrote:
+/rubygem-aeolus-image.spec
Minor thing here - you must have added this file locally in a separate
commit, as it does not appear on master, causing this patch to not
apply. I'll skip it and test the rest for now though.
-j
Yes this file is not under source control, but it gets autogenerated every time
I run rake specs (I run them via `bundle exec rake spec`). I think this
shouldn't happen, but I didn't go deeper into this and see why this happens, as
this issue is no big deal but I presume it would take some time to solve. So I
wanted to gitignore the file like other files/dirs that get autogenerated and
shouldn't be under SC (.bundle directory etc.).
Anyway I can resubmit the patch without this commit if needed. Please let me
know if you still want to remove this commit.
J.
I was actually fine with adding that, just for some reason yesterday
the patch did not apply. I just tried it again, and it is now fine,
so I pushed it. The rest I pushed yesterday, just forgot to reply to
list, so ACK to the lot, good work.
-j
