On Fri, Sep 21, 2012 at 10:28:39AM -0400, [email protected] wrote:
> From: Tzu-Mainn Chen <[email protected]>
> 
> ---
>  src/app/views/providers/index.html.haml |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/app/views/providers/index.html.haml 
> b/src/app/views/providers/index.html.haml
> index be644b0..b16033f 100644
> --- a/src/app/views/providers/index.html.haml
> +++ b/src/app/views/providers/index.html.haml
> @@ -11,9 +11,9 @@
>        %li
>          = hidden_field_tag :current_path, request.fullpath
>          = t('filter_table.from')
> -        = select_date @from_date, :prefix => :from_date
> +        = select_date @from_date, :prefix => :from_date, :order => [:year, 
> :month, :day]
>          = t('filter_table.to')
> -        = select_date @to_date, :prefix => :to_date
> +        = select_date @to_date, :prefix => :to_date, :order => [:year, 
> :month, :day]
>          = restful_submit_tag t("filter_table.apply_filters"), "index", 
> filter_providers_path, 'POST', :class => 'button', :id => 
> 'apply_provider_index_filter'
>          %span.label.badge.dark= @providers.count
>      = filter_table(@header, @providers) do |provider|
> -- 
> 1.7.6.5

NACK. (No offense!)

The real root cause of this bug is that we had a language file, but not
corresponding default language file -- e.g., we'd have locales/it.yml,
but not locales/defaults/it.yml, which is where things got tripped up.

Specifying a sort order here is a big-hammer solution to override
locales. We shouldn't have to do that.

eb8b4eed added the missing locales in 1.1, but not upstream. So the 1.1
blocker bug is fixed by that commit. We just need to bring those locales
upstream and then we're golden.

-- Matt

Reply via email to