On Tue, Jan 10, 2012 at 11:49 PM, Roger Martín <[email protected]> wrote: > Hi folks! > > config class works in the backstage as a layer over old config array. It's > incomplete for two reasons: > - source php must reviewed to replace $config array to use config_get or > config class.
We should totally move to your config class. You made config class compatible, so we need to just clean the codebase and use your class IMO, which brings us up to date with multi-views, multi-sites, and multi-languages. > - there are no way to edit config vars stored in table aiki_configs (note > ending s), for two reason: i don't know how to do it in actual aiki admin, > and i don't know how to change aiki admin, adequate for admin one site, to > manage multi-site. Magento, for example, has this solution: you can select > site,view,etc, and then change his setting. Jakub, is this something you can help with? I think we should go the other way, make sure that the data stored by config class is editable. We need though to make sure that there is a simple upgrade path for people to switch over their installation to the new class. Best case is to support both the old config.php and config, and then the new one. We could have a switch in the code so that new aiki installs use the new system, but old ones use the old one. When the updater code is ready, we can make this change happen to others installations. Sound good or too complicated? > > About config.php and def.php > - delete def.php. it's very confuse.. Yes, I agree. Lets put all the content of def.php into config/config.php then. Should config/config.php be read each load then? That is the point of def.php to be read on every load of the site to get constants. I don't care honestly as long as the solution is simplified, and consolidates the locatin of configs and defines. Even in bootstrap.php there are more defines like version number. Others have opinions on? > - minimize config.php: only database connection and certain setting that > must exist before config class can be loaded (for example logs dirs). > Remenber a config.php file can't manage multisite configuration, use > database (like wordpress). > are we agree in these points? Yes, totally agree. Jon -- Jon Phillips 王✳爻气 http://fabricatorz.com ✳ skype: kidproto ✳ irc: rejon +1.415.830.3884 (global) ✳ +86-187-1003-9974 (beijing) _______________________________________________ Mailing list: https://launchpad.net/~aikiframework-devel Post to : [email protected] Unsubscribe : https://launchpad.net/~aikiframework-devel More help : https://help.launchpad.net/ListHelp
