To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Fri Dec 2 20:57:40 -0800 2005 ------- In message "[Issue 53572] MinGW port efforts and information for SRC680 codeline", [EMAIL PROTECTED] wrote... >@tono: Please, review >shell/inc/internal/i_xml_parser_event_handler.hxx : two additional typedef >whithout "#ifdef" "#ifdef should be inserted. This modification relates to the unicode type and may not be required if I change tye definition. In unicode expat, it can be wchar_t and ushort by switches. To keep consistency with the current definition, it would be better to use wchar_t but if we choose so, the internal expat message becomes unicode as well and it requires conversion on errors. Therefore I abandoned to use wchar_t here and use casts. These typedefs are intendend to simplify cast codes but I think it is not good. >moz/mozilla-source-1.7.5.patch: LIB_PREFIX is thrown away. Why? Why just not >undefine LIB_PREFIX? Please, review I would like to use LIB_PREFIX only for import libraries and I think it would do no harm for platforms that do not define LIB_PREFIX. >svx/source/dialog/makefile.mk: why $(SLO)$/dialmgr.obj is simply thrown away? I thought that cui shared library is a user of gui library and do not have to have duplicate obj. But it does not relates to porting if it is linked dynamically. I will eliminate this modification. >svx/source/msfilter/mscodec.cxx line 247: this method needs sal_uInt16, please >convert input data before calling the method. The same is true for >svx/inc/mscodec.hxx, line 212 I assumed that this code is intended for unicode string as the code requies the input null terminated. But the assumption might have gone too far. I will modify as you recommended. >dbaccess/source/ui/dlg/makefile.mk line 49: Why not in >".IFDEF"?idlc/source/parser.y, lines 129-139. The block is now only for >(_MSC_VER) && (_MSC_VER < 1310). Is that your intent? This chunk of code seems to be no longer needed as stlport 4.5 or later includes a header file with malloc. tono (Takashi Ono) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
