To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=64717
User as changed the following:
What |Old value |New value
================================================================================
Assigned to|as |kendy
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Thu May 11 04:07:11 -0700
2006 -------
a)
The method openTarget() (as the name suggest) would be designed to return
TARGET
files, ready for reading AND (!) writing on the user layer. So changing that
would break
the interface of the PresetHandler class.
Solution: Move returning a storage related to your new m_xWorkingStorageNoLang
member from openTarget() to openPreset(). Of course
acceleratorconfiguration.cxx has
to be changed accordingly.
b)
I wouldnt say "it's an error" ... it's more "the simplest way to implement
handling of two
layers" .-) Anyway: your implementation reach also a state, where the full
configuration
will be stored on the user layer. Please use the following steps to reproduce
that:
- start without a user layer
- open a writer
- type some letters into the document
=> as a result of that the localized default.xml from "en-US/default.xml" was
copied to
the user layer.
- open inside the "Tools->Customize" dialog the "Keyboard" tab page
- change something there and press OK
=> now the full content of the accelerator cache was flushed to the user layer
.-)
So your implementation does not solve this "problem" - which isnt realy a
problem for
me (currently). But using the normal XCS/XCU configuration for accelerators
will solve
it.
c)
Your problems show me, that it would be easier to change the implementation to
the
XCS/XCU configuration .-)
Because ...
d)
... your patch doesnt work for our "Tools->Customize->Keyboard" tab page.
E.g. changing existing shortcuts works only in case the office will be started
new.
Further you should use a debug version for testing. There is an assertion from
the xml
reader class, that existing keys will be not overwritten by new keys. May be
you should
change this code in a way, that it overwrites even existing keys without
showing a
warning. But then you have to change the order of reading the different files.
Because
then m_xWorkingStorageNoLang has to be readed first, before
m_xWorkingStorageUser is asked for content. Otherwhise you overwrite user
defined
keys.
Regards
Andreas
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
