To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=66722
------- Additional comments from [EMAIL PROTECTED] Fri Jul 21 05:59:03 -0700 2006 ------- Thanks kendy for presenting your position. I will try to present mine, so that sb can chose with knowledge of both points of views. "The common KDE header will be used in just about 10-20 .cxx's" ... yes, and it already refers 37 headers. When doing the multiplication, one can see that the impact on compilation time will be non neglectable if we include every KDE and Qt header without distinction. The other advantage of the #ifdef's is to force the same semantics as usual #includes. It's the same situation as declaring your variables: carefully choosing the files which you will include makes you code better. With code review or not ;-). It's not harder to use kde_headers.h than to use usual #includes... Oh, well, there are n+1 lines where you would have used n. No big story, I think. In any case, with #ifdef's or not, the common wrapper seems a good thing to me. So whatever sb decides we will move forward :-). --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
