To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Tue Sep 19 08:17:25 -0700 2006 ------- @tono: There are many changes where you do a reinterpret_cast<LPWSTR> (and similar) to cast from a rtl::OUstring::getStr() to the Windows API unicode strings. I don't understand why this is neccessary. The Windows API, Platform SDK etc define those wide string types as typedef WCHAR *LPWSTR; and #ifndef MAC typedef wchar_t WCHAR; #else typedef unsigned short WCHAR; // Iguess this applies for mingw too #endif You also changed the definition of sal_Unicode in sal/types.h. I guess that is because wchar_t with mingw gcc is not 16 bit as with microsoft compiler but 32 bit. You made a typedef sal_uInt16 sal_Unicode; This is binary compatible but not type safe. So why didn't you do the following in sal/types.h for mingw port: typedef unsigned short sal_Unicode; or use the type that is used in your windows.h for a WCHAR. Then you can get rid of those hundreds of unneccessary casts that are not typesafe. Unless there is no real need to do so I would not like to make use of those c-style casts. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
