To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=76159





------- Additional comments from [EMAIL PROTECTED] Tue Apr 10 07:42:56 +0000 
2007 -------
The question is why Panther sets errno to EINVAL (as per jkim's information):

1  Does it mean that sysconf(_SC_GETPW_R_SIZE_MAX) does not have a limit on
Panther, but Panther in violation of SUSv3 sets errno to EINVAL instead of
leaving it unchanged?  In that case, the fix of treating errno==EINVAL similar
to errno==0 would be ok.

2  Or does it mean that Panther does not support getpwnam_r, getpwuid_r, and
_SC_GETPW_R_SIZE_MAX at all (SUSv3 lists getpwnam_r and getpwuid_r as optional
thread-safe functions)?  In that case, another fix would be necessary.

Routinely returning NULL from newSecurityImpl on Panther, even if all callers
would handle it properly, would probably not be very helpful:  This should be a
rare error condition (indicating that something very fundamental is broken), not
the norm.

Anyway, I would make the fix for (1) more explicit than the attached patch (and
more consistent regarding layout), something like

    if (errno == 0
  #ifdef ...Panther...
        /* sysconf(_SC_GETPW_R_SIZE_MAX) erroneously reports EINVAL on ...: */
        || errno == EINVAL
  #endif
       )
    {

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to