To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78495


User mhu changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |STARTED
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Fri Jun 15 16:44:06 +0000 
2007 -------
Hi Michael,

Yes, indeed we're doing CRCs on every Page(header) read from disk. And this is
still regarded as useful, in that we can detect inconsistencies, and report them
(in that a read may fail with "store_E_InvalidChecksum").

The refactoring, that I'm working on, will take the amount of cpu cycles spent
on this into account by not wasting cycles through repeated CRC checks (caused
by repeated reads of the same pages).

Thus, to me the proper change seems to be a revised page lifecycle with improved
caching of pages, and not simply removing the checks (which, if your patch would
be integrated verbatim, would lead to unreachable code).

But, I'm taking this issue, which correctly describes a profiled performance
observation, to justify the changes that I have in progress. More on that later.

Thanks,
Matthias

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to