To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78747
------- Additional comments from [EMAIL PROTECTED] Fri Jul 13 18:01:02 +0000 2007 ------- > The approach is wrong, and for sure we don't want to see the > fprintf stuff there. Wow - it seems everyone is obsessed by printf's :-) > The right approach is to rely on VCLEVENT_BUTTON_CLICK, because > only this way multiple listeners are possible. ClickHdl allows > only 1 listener. Did you actually read the patch & rational ? :-) the ClickHdl is -only- set in order to stop the "default action" being taken inside VCL - the fprintf is intended to show that the contents of the Hdl is irrelevant. > So to fix it, trigger the event in VCL before calling the virtual > "Click" method, if possible. Sounds like a difficult-to-predict-the-impact event ordering change in vcl. > If not possible, make sure the Click() methods from the special buttons > call the base class. I can but that as a solution; but what is to stop these buttons from doing their "default" action (which is to grope around the VCL window tree & do strange things :-) - ie. should we not set a no-op ClickHdl on them anyway ? > For some reason we did the following some time after creating AWT: When > you create a dialog via the toolkit, the closer won't close the dialog > automatically. It surely does (for me) for "Cancel" if you run Application::Execute - on the other hand 'OK' does not ;-) - hence the confusion. > So when I use an OK/Help button, what does the user want. Does he want > default behavior, or just a buttom with the localized text? > I don't know. Probably default behavior is fine here. So - the conclusion of your thoughts is (I assume) that you want VCL fixed to just chain to the parent, and the default action to always, unconditionally & un-controllably get invoked ? ie. via. AWT there would be no way of turning this 'default' functionality off. ie. if you want a 'Cancel' button it will auto-cancel the dialog whatever you do ? - if so, do you even care that the AWT UNO API gets no 'Click' event - after all, the action will be done by then anyway. Ulimately, I guess I don't mind; I'm resigned to having to emulate the old behavior in the wrapper. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
