Hi Wei Zhao,

Thanks for the patch. I think the feature works fine now :-) . Good work! I will integrate it to CWS chart19 thus it will be in OOo 3.0.

What was not so nice is that the patch could not be applied without special treatment. In the offapi part of the patch the directory 'sun' is missing in the path. In the chart2 part of the patch the part for file res_Titles.cxx does not apply. Do you know the reason for this trouble thus we can avoid it in future? Maybe it would be more safe to create the patches using cvs:
cvs diff -c > mypatch.patch.

Another thing: I recognized that you changed back the numbers for the new help ids in HelpIds.hrc. It was no accident that I left space for number 91 because help id HID_SCH_START+91 is already assigned for another feature in CWS chart17. So I prepared to avoid merge conflicts in future. Sorry that I had not made that clear enough.

See you tomorrow in the chat :-) ,
Ingrid

[EMAIL PROTECTED] wrote:
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=1163





------- Additional comments from [EMAIL PROTECTED] Thu Nov 15 06:30:20 +0000 
2007 -------
->iha, bm: The new patch for this issue is submitted. Please find the final attachment. Please let me know if I miss anything.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to