To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=84259
User fs changed the following:
What |Old value |New value
================================================================================
CC|'aziem' |'aziem,fs'
--------------------------------------------------------------------------------
Assigned to|fs |kendy
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Fri Dec 21 21:41:20 +0000
2007 -------
fs->kendy: As much as you have my sympathy for the intention of the fix ...
The change in fmview.cxx
a) introduces code which will not be understood in half a year anymore
(Huh? "If ( IsDesignMode() ) pShell->SetDesignMode( true )"?)
b) uses an implementation detail of the FmXFormShell (namely the fact that
the SetDesignMode calls ResetForms)
c) is prone to future breakage (in particular if somebody introduces an
optimization in SetDesignMode to don't do anything when the mode did
not actually change).
For all three reasons, I consider this code a maintenance problem. And yes, the
*whole* code in those classes is a maintenance problem, but we do not need to
make it worse :)
I suggest you make more explicit what's going on there. For instance, introduce
some "initForms", where the latter collects the code around the GetForms call in
SetDesignMode (and is also called from there).
Also, I'd prefer having some haveForms instead of the direct access to m_xForms
(those friend declarations and usages are a pain in the neck, and should be
removed), but that's optional :)
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
