To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=84259


User fs changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Sun Dec 23 13:20:12 +0000 
2007 -------
The attached patch is what I committed to dba24e.

Two notes:

1. The UpdateForms call in ObjectCreated still tastes slightly hacky to me. A
cleaner solution would probably some kind of callback from the FmFormPage to the
FmFormShell which indicates the creation of forms. But since the form page
associated with a form shell changes over time, that sounds like too much
overhead for me ATM.

2. There was a time when the FmFormShell was created only when needed, not at
the time of creation of the document. Not sure when this time had gone,
actually. I know we spent a lot of effort into virtualizing the dbtools-API
which is used in the form layer, exactly to prevent the dbtools lib being loaded
when SVX is loaded. Seems this has been torpedoed by the "always create the
FmFormShell" thing.
Conclusion: Even what we gained with this patch won't last too long, if we don't
establish measures that we do not re-introduce those dependencies.

Anyway. Fixed in CWS dba24e for the moment. Kendy, thanks for the inspiration
and the patch.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to