To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=29152
User kso changed the following:
What |Old value |New value
================================================================================
Assigned to|tkr |kendy
--------------------------------------------------------------------------------
Status|STARTED |NEW
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Fri Mar 28 08:34:42 +0000
2008 -------
kendy: Some comments after quickly reading the diff for CWS
webdavandgvfslocking1.
- Seems, that you put your fix for #i84137# "Remove gnome-vfs from startup
procedure" into this CWS (without adding the task to the CWS, btw.) As you know
I cannot accept this fix, because it violates UCB design constraint not to use
solar libs. OTOH, I cannot see how this changes are related to gnome-vfs file
locking. Please remove the changes for #i84137# from this CWS. Let's deal with
this problem another time.
- remove comphelper::getProcessServiceFactory() calls. Use the service
factory/component context that was used to create the UCP.
- remove the hack to create your own Interaction Handler in case none is
available (DAVResourceAccess::createCommandEnvironment()). The code calling the
UCB must be changed to provide the right Interaction Handler, if one is needed.
- remove the hard cast from XStream to NeonInputstrem you're doing in
webdavcontent.cxx in order to be able to call NeonInputStream::SetLock(). This
is a hack, isn't it.
- I don't really like that locking is only done in case an XActiveDataStreamer
is supplied with the "open" command. What about XOutputStream, XActiveDataSink
"open"-variants?
- Is the implementation of property "IsReadOnly" and "SupportactiveStreaming" is
not acceptable as it is now => Remove the "if ( rProperties.getLength() == 1 )"
stuff. What is this good for?
- "IsReadOnly" implementation seems to be a hack, too. Why is the value only
avail in case m_bForceReadOnly is true? The property should always be available.
The correct value should be obtained by inspecting the webdav-locking state of
the resource.
More comments to follow after I found the time to do a detailed analysis of your
changes ;-)
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
