To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=90956
User mst changed the following: What |Old value |New value ================================================================================ Status|NEW |STARTED -------------------------------------------------------------------------------- ------- Additional comments from [EMAIL PROTECTED] Mon Jun 23 09:39:30 +0000 2008 ------- hi rene, thanks for the patch! > - without BUILD_TYPE extended to contain REDLINE those dependency will never > have an effect which will then of course break because redland s not built ok, committed. > - scp2 has the #ifdefs but in the makefile.mk there's no define set for it, so > this one will never have an effect either aha, ingo forgot to tell me about that... committed. > - and finally, configure doesn't contain a check and set the environment > variables/BUILD_TYPE (including REDLAND_LIBS which is already referenced in > solenv/inc/libs.mk). hmm; i am not sure whether it is a good idea to enable building against system redland right now; i found a couple of bugs in current version 1.0.7. i've sent patches to the redland-dev list (unfortunately i do not know how many were merged). if one of the patches is missing, the office will crash due to missing input argument checking in redland destructor functions as soon as the service css.rdf.Repository is instantiated. the other patches are not that important, they only fix bugs that yield incorrect results :) so, i guess it would be best to use only internal redland, unless system redland is of a version that has the fixes, which is... not released yet. hmm. i guess for now i will change your patch like this: dnl if test -n "$with_system_redland" -o -n "$with_system_libs" && \ dnl test "$with_system_redland" != "no"; then if test -n "$with_system_redland" && \ test "$with_system_redland" != "no"; then so you do not get system redland with --with-system-libs, only with --with-system-redland, so downstream is responsible for supplying new enough/patched redland. do you have any better suggestion? (and i fixed a typo in your patch...) > Should be fixed (Yes, I looked in odfmetadata2 but it doesn't do anything on > these) in odfmetadata before being RfQA (can't enter a comment there bcecause > of > missing due date set...) the ability of entering comments depends on whether a due date is set? the stupidity of our web apps never ceases to amaze me.... (oh, you may thank $DEITY that you don't have to use sun-internal IBIS ...) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]