To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=103200
------- Additional comments from t...@openoffice.org Fri Jul 31 02:41:59 +0000
2009 -------
tora -> bluedwarf:
Could you refactor your patch to encapsulate a logic like this?
This is just an idea. You can devise it in your preferable way.
// $SOLARVER/$INPATH/inc/offuh/com/sun/star/lang/Locale.hpp
#include <com/sun/star/lang/Locale.hpp>
#include <vcl/settings.hxx>
class NameOfPerson
{
public:
NameOfPerson();
~NameOfPerson();
// The default locale could be internally retrieved from
AllSettings::GetUILocale()
void setUILocale( const ::com::sun::star::lang::Locale& rLocale );
const ::com::sun::star::lang::Locale& getUILocale();
// accessors for meaning layer
void setFamilyName( const OUString& rousName );
void setGivenName( const OUString& rousName );
OUString& getFamilyName();
OUString& getGivenName();
// accessors for presentation layer
void setFirstPositionNameText( const OUString& rousName );
void setSecondPositionNameText( const OUString& rousName );
const OUString& getFirstPositionNameText();
const OUString& getSecondPositionNameText();
const OUString& getInitial();
const OUString& getLabelTextOfFirstPositionName();
const OUString& getLabelTextOfSecondPositionName();
const OUString& getCombinedNameTextForTheGivenLocale( sal_Unicode cDelimiter
= 0x0020 );
};
IMHO, we should not have these type of code fragments here and there
within the entire OpenOffice.org source code tree:
if ( LANGUAGE_JAPANESE == eLang ||
LANGUAGE_KOREAN == eLang ||
LANGUAGE_CHINESE_TRADITIONAL == eLang ||
LANGUAGE_CHINESE_SIMPLIFIED == eLang)
// swap "first name" field and "last name" field
Point aPosTmp = aFirstName.GetPosPixel();
aFirstName.SetPosPixel( aName.GetPosPixel() );
aName.SetPosPixel( aPosTmp );
aFirstName.SetZOrder( &aName, WINDOW_ZORDER_BEHIND );
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@l10n.openoffice.org
For additional commands, e-mail: issues-h...@l10n.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
