To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109791
------- Additional comments from s...@openoffice.org Wed Mar 3 21:30:33 +0000 2010 ------- @rene: A few things come to mind: 1 libs.mk CPPUNITLIB: For one, shouldn't the check for SYSTEM_CPPUNIT come before the check for WNT (so that WNT could, at least in principle, also use SYSTEM_CPPUNIT)? For another, the "+=" in "CPPUNITLIB += $(CPPUNIT_LIBS)" is probably a typo. (And for a third, wouldn't it be better to replace CPPUNITLIB with CPPUNIT_LIBS everywhere and set it in libs.mk only if not SYSTEM_CPPUNIT?) 2 What looks odd is that only sal/cppunittester/makefile.mk mentions CPPUNIT_CFLAGS, not the other makefiles that reference cppunit. (And again, wouldn't it be better if the CFLAGS+=CPPUNIT_CFLAGS would be unconditional, and CPPUNIT_CFLAGS were set empty for the non-SYSTEM_CPPUNIT case in some solenv/inc/*.mk?) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org For additional commands, e-mail: issues-h...@tools.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
