To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109791
------- Additional comments from s...@openoffice.org Thu Mar 4 09:16:39 +0000 2010 ------- >> 1 CPPUNIT_CFLAGS should probably always only be added to CXXFLAGS, never to >> CFLAGS. > > maybe, but CFLAGS works and is consistent with the rest. Technically, CFLAGS works (as CFLAGS is added to C++ compilation in addition to CXXFLAGS), but CXXFLAGS would be more correct. Anyway, even if you want to keep using CFLAGS for consistency, please clean up the places that now have both, CFLAGS+=CPPUNIT_CFLAGS and CXXFLAGS+=CPPUNIT_CFLAGS. >> That is, configure should fail >> for --with-system-cppunit/--without-system-stl combination. I am not (yet) >> sure what the minimal required version is, though. > > Well, I guess we can just use 1.12, no? Shouldn't matter much as we didn't > have > that flag before anywy. Probably good, yes. If somebody ever has a need for a lower version, they can check to modify this then. > Wrt STLport: no way, if you really have a STL conflict (like we ha(d/ve) with > graphite and mysqlc) apply a workaround like the one caolan did for graphite > already (see issue 106157); it is bad to use system-cppunit on everything > except i386. Better all or none.... You unfortunately cannot work around that here. The interface of CppUnit is full of std-types, so the OOo test code calling CppUnit and CppUnit itself have to use the same STL implementation. However, the OOo test code also shall access OOo code that has std-types in its respective interface, so those two need to use the same STL implementation, too. We can only improve things here when we eventually drop the STLport-requirement (and become URE-incompatible on the affected platforms). --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org For additional commands, e-mail: issues-h...@tools.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
