> > snd_pcm_hardware_t is NOT pre-initialized, and drivers are responsible to > > define ALL fields necessary. This is too bad, because it essentially means > > that a new constraint (i.e. period_size_min + period_size_max) will need > > to be supported by all drivers. > > well, but drivers supporting G72x are very rare. > then why bother to change the common code to affect every driver?
I sent a consolidated patch with the G.72x stuff of last week and the constraint problem of today. Both matters are unrelated, and I apologize for the inconvenience. Please note that the G.72x stuff has no effect on existing drivers, and therefore I would hope that it is accepted as well (rather than me maintaining it separately). > > I have tested successfully such a new constraint (patch in attachment), and > > hope that you'll incorporate it in the cvs anyway. > > it'd be better to add the constraint only if the period_size_min and > max are non-zero, since most of drivers do NOT want to use this > constraint. > the similar should be applied to the period_bytes constraint if we > add period_size constraint, because they may conflict with each > other. Agreed. I'll change that and send the patch (for the constraint stuff ONLY ;) to you directly. Note this assumes that the compiler automatically sets undefined members of the structure to zero. Cheers! Guilhem. __________________________________________________ Do You Yahoo!? Yahoo! Finance - Get real-time stock quotes http://finance.yahoo.com ------------------------------------------------------- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel
