Hi Benny, the changes look ok, but i'd like to ask your favor before applying this patch.
could you move the SCB initialization part in cs46xx_playback_prepare() into hw_params callback? i found that the mutex is not allowed in prepare callback since it's protected by spinlock (at the very entry of prepare action). this caused oops on 2.5.x kernels, as you might have seen a report on alsa-devel ML. please note that hw_params callback may be called also not only once, so you'll need to check whether the SCB was already initialized, and release the old allocation before re-initializing. also, it would be appreciated if you fix the whitespaces :) ciao, Takashi ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel
