Fernando Pablo Lopez-Lezcano <[EMAIL PROTECTED]> writes:
> > > > > I think we need a similar extension to support Mandrake,
> > > > > after installation from the sources all modules in
> > > > > modules.conf where gone, except the ones from alsa.. :-)
> > > >
> > > > I think the patch will fix mandrake too. I have the dubious
> > > > honor of being able to claim ownership of the original bug :-(
> > > > Anything having a /etc/redhat-release file but without having
> > > > "Red Hat" inside would trigger the bug.
> > > >
> > > > The currently result with Mandrake would be to use the SuSE
> > > > filter to try to erase the oss preferences from
> > > > modules.conf. If the RedHat filter is better then another "if"
> > > > could be added to the distro selection code to include
> > > > Mandrake.
> > >
> > > untested:
> >
> > shall i apply this? let me know.
>
> I think it does no harm but does not change the end result
> either. It creates a new option ("mandrake") but there is no code to
> handle it so the if's should just execute the SuSE (default) code as
> they do now.
>
> Options:
> a) define 'distribution="redhat"' for the mandrake detection code
> _if_ the oss options erasure for redhat works fine under mandrake
> (mandrake users should test this).
> b) add another handler for mandrake's modules.conf oss options
> (should be written taking into account whatever mandrake uses to
> configure sound so that the proper strings are removed from
> modules.conf).
so why not doing such as threat all distros that provide
/etc/redhat-release the same way. i don't think there's any distro
out that provide /etc/redhat-release for compatibility that would like
to have users loose their module configuration:
Index: alsaconf/alsaconf.in
===================================================================
RCS file: /cvsroot/alsa/alsa-utils/alsaconf/alsaconf.in,v
retrieving revision 1.5
diff -u -p -r1.5 alsaconf.in
--- alsaconf/alsaconf.in 24 Nov 2003 11:42:24 -0000 1.5
+++ alsaconf/alsaconf.in 24 Nov 2003 19:40:54 -0000
@@ -24,10 +24,8 @@ if [ -f /etc/SuSE-release -o -f /etc/Uni
distribution="suse"
elif [ -f /etc/debian_version ]; then
distribution="debian"
-elif [ -f /etc/redhat-release -a `grep -c "Red Hat" /etc/redhat-release 2>/dev/null` != 0 ]; then
+elif [ -f /etc/redhat-release ]; then
distribution="redhat"
-elif [ -f /etc/fedora-release -a `grep -c "Fedora" /etc/fedora-release 2>/dev/null` != 0 ]; then
- distribution="fedora"
else
distribution="unknown"
fi
@@ -548,7 +546,7 @@ Do you want to modify ${cfgfile}?" 8 50
SOUND_CORE="snd"
fi
- if [ "$distribution" = "redhat" -o "$distribution" = "fedora" ] ; then
+ if [ "$distribution" = "redhat" ] ; then
remove_ac_block < $cfgfile | remove_sndconfig_block | uniq > $TMP
else
remove_ac_block < $cfgfile | remove_y2_block | uniq > $TMP
