Hi All.
I am using amanda-2.6.1p1 on some of my linux servers and considering
whether I should upgrade the version of Amanda on thses servers to
2.6.1p2.
Now, I am inspecting each patch between 2.6.1p1 and 2.6.1p2.
I understood almost of these patches are for bug fix or
adjustment of packaging rules, but there is one patch I cannot
infer what situation it works.
The patch is for REV2126.
By this patch, amrestore calls device_configure() after calling
device_open() when it attempt to restore data from tapes.
Amanda-2.6.1p1 doesn't do this but it runs sanely at least
I confirmed.
Under what circumstances does this patch make sense?
Or other words, what case amrestore cannot run sanely
without this patch?
The following snippet is the part of the patch
I am asking about.
Index: restore-src/amrestore.c
===================================================================
--- restore-src/amrestore.c (revision 2122)
+++ restore-src/amrestore.c (revision 2126)
@@ -110,6 +110,11 @@
error("Could not open device %s: %s.\n", device_name,
device_error(device));
}
+ if (!device_configure(device, TRUE)) {
+ error("Error configuring device: %s",
+ device_error_or_status(device));
+ }
+
if (!set_restore_device_read_buffer_size(device, flags)) {
error("Error setting read block size: %s.\n",
device_error_or_status(device));
}
