----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review298 -----------------------------------------------------------
shared/FileType.cpp <http://git.reviewboard.kde.org/r/100088/#comment242> QStringList::contains by default uses case sensitive search. shared/FileType.cpp <http://git.reviewboard.kde.org/r/100088/#comment243> indexOf also case sensitive. May be just write something like: int pos = -1; if( ( pos = s_fileTypeString.indexOf( extension.toLower() ) ) != -1 ) return Amarok::FileType( pos ); else return Amarok::Unknown; It also exclude double run over list. - Sergey On 2010-11-04 21:24:56, Stefan Derkits wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100088/ > ----------------------------------------------------------- > > (Updated 2010-11-04 21:24:56) > > > Review request for Amarok. > > > Summary > ------- > > -) Created new Class with some Helper Functions > -) Changed MetaQueryWidget to use the QStringList that contains all Filetypes > -) Meta::SqlTrack.type() now gets it's Information from the Database instead > of the FileExtension > > > Diffs > ----- > > shared/FileType.cpp PRE-CREATION > src/browsers/CollectionTreeItemModelBase.cpp b5daa4d > src/core-impl/collections/support/MemoryFilter.cpp e2509ac > src/widgets/MetaQueryWidget.cpp 0249edf > tests/synchronization/CMakeLists.txt e5df2df > shared/FileType.h 55c80b9 > > Diff: http://git.reviewboard.kde.org/r/100088/diff > > > Testing > ------- > > Tested in the App, found no wrong Behaviour > > > Thanks, > > Stefan > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
