----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/ -----------------------------------------------------------
(Updated 2010-11-05 17:22:43.248928) Review request for Amarok. Changes ------- use constant Reference instead of copying the parameter; changed FileType.h & FileType.cpp to amarok Coding Style; start iterating through FileTypes at 1 instead of 0 (fileextension will probably never be "other" :) ) Summary ------- -) Created new Class with some Helper Functions -) Changed MetaQueryWidget to use the QStringList that contains all Filetypes -) Meta::SqlTrack.type() now gets it's Information from the Database instead of the FileExtension Diffs (updated) ----- shared/FileType.h 55c80b9 shared/FileType.cpp PRE-CREATION src/browsers/CollectionTreeItemModelBase.cpp 3f64a73 src/core-impl/collections/support/MemoryFilter.cpp e2509ac src/widgets/MetaQueryWidget.cpp 0249edf tests/synchronization/CMakeLists.txt e5df2df Diff: http://git.reviewboard.kde.org/r/100088/diff Testing ------- Tested in the App, found no wrong Behaviour Thanks, Stefan
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
