----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review9846 -----------------------------------------------------------
Some problems with plural localization. Apart from that the fix looks harmless. src/browsers/CollectionTreeItemModelBase.cpp <http://git.reviewboard.kde.org/r/103603/#comment8155> The text scanner will not pick this text up. Use i18np for that. src/browsers/playlistbrowser/PodcastModel.cpp <http://git.reviewboard.kde.org/r/103603/#comment8156> Same here. i18np - Ralf Engels On Jan. 4, 2012, 12:52 a.m., Lucas Gomes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103603/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2012, 12:52 a.m.) > > > Review request for Amarok and Bart Cerneels. > > > Description > ------- > > This is my attempt to make QTreeView subclasses items, used in Amarok, more > pretty by displaying some extra information. Notice that these extra > information are usually the quantity of tracks in a album, the quantity of > episodes in a podcast and the quantity of episodes marked as new in a podcast. > > So, please help me to improve this feature even more by answering some > questions: > > 1) Should I show the quantity of tracks on playlists listed in > PlaylistBrowser too? > 2) Is there any extra information that you think it's relevant to be showed > somewhere (In QTreeViews)? > > Link for my personal repository (Look for ui-improve branch): > http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary > > > Diffs > ----- > > src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 > src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 > > Diff: http://git.reviewboard.kde.org/r/103603/diff/diff > > > Testing > ------- > > This patch should build. Everything is working as expected and there aren't > any known issues. > > > Screenshots > ----------- > > CollectionBrowser > http://git.reviewboard.kde.org/r/103603/s/401/ > PodcastBrowser > http://git.reviewboard.kde.org/r/103603/s/402/ > > > Thanks, > > Lucas Gomes > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
