----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review10114 -----------------------------------------------------------
Hmm, either I'm completely dumb or v4 of the patch you submitted is not a difference between Amarok master and the desired code, but a difference between previous version of the patch and the desired code. Please submit a patch that will apply to amarok master by itself. Thanks for removing the track count from collection browser. Speaking about alignment, I think you misunderstood the review, my interpretation is that: * album images in podcast browser should be left at 32 pixel size * alignment issue was that the space between upper border of the row and the "6 Minute English" should be equal to the space between the lower border of the row and "1 (o new) episode". E.g. to move the whole text slightly upwards. Screenshot: PodcastBrowser <http://git.reviewboard.kde.org//r/103603/#scomment29> Should be moved upwards. - Matěj Laitl On Jan. 27, 2012, 1:11 a.m., Lucas Gomes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103603/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2012, 1:11 a.m.) > > > Review request for Amarok and Bart Cerneels. > > > Description > ------- > > This is my attempt to make QTreeView subclasses items, used in Amarok, more > pretty by displaying some extra information. Notice that these extra > information are usually the quantity of tracks in a album, the quantity of > episodes in a podcast and the quantity of episodes marked as new in a podcast. > > So, please help me to improve this feature even more by answering some > questions: > > 1) Should I show the quantity of tracks on playlists listed in > PlaylistBrowser too? > 2) Is there any extra information that you think it's relevant to be showed > somewhere (In QTreeViews)? > > Link for my personal repository (Look for ui-improve branch): > http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary > > > Diffs > ----- > > src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION > src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION > src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 > src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp > PRE-CREATION > src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp > PRE-CREATION > src/browsers/CollectionTreeItem.h 3438adc > src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 > > Diff: http://git.reviewboard.kde.org/r/103603/diff/diff > > > Testing > ------- > > This patch should build. Everything is working as expected and there aren't > any known issues. > > > Screenshots > ----------- > > CollectionBrowser > http://git.reviewboard.kde.org/r/103603/s/420/ > PodcastBrowser > http://git.reviewboard.kde.org/r/103603/s/421/ > > > Thanks, > > Lucas Gomes > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
