> On June 25, 2013, 3:42 p.m., Mark Kretschmann wrote: > > src/amarokconfig.kcfg, line 583 > > <http://git.reviewboard.kde.org/r/111212/diff/2/?file=165600#file165600line583> > > > > Why does this need a configuration option? Can you think of any use > > case where a user would not want to be warned?
Maybe not. I didn't when I was running benchmarking, but I doubt that's usual. > On June 25, 2013, 3:42 p.m., Mark Kretschmann wrote: > > src/amarokconfig.kcfg, line 588 > > <http://git.reviewboard.kde.org/r/111212/diff/2/?file=165600#file165600line588> > > > > Why would the user want to change the interval? I don't think anyone > > could tell what impact this has. Okay. - Anmol ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111212/#review35037 ----------------------------------------------------------- On June 24, 2013, 4:10 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111212/ > ----------------------------------------------------------- > > (Updated June 24, 2013, 4:10 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Added the ability to kill a long running script. > Refactored a bit. > > > Diffs > ----- > > src/ScriptManager.h afaa832 > src/ScriptManager.cpp b7f0a5c > src/amarokconfig.kcfg 6b4cefe > src/configdialog/dialogs/ScriptsConfig.ui b4b8d37 > src/scriptengine/AmarokScriptableServiceScript.cpp a312671 > > Diff: http://git.reviewboard.kde.org/r/111212/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel