----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111212/#review35095 -----------------------------------------------------------
src/amarokconfig.kcfg <http://git.reviewboard.kde.org/r/111212/#comment25679> Please do actually remove the options, including the GUI for them too. - Mark Kretschmann On June 25, 2013, 1:49 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111212/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 1:49 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Added the ability to kill a long running script. > Refactored a bit. > > > Diffs > ----- > > src/ScriptManager.h afaa832 > src/ScriptManager.cpp b7f0a5c > src/amarokconfig.kcfg 6b4cefe > src/configdialog/dialogs/ScriptsConfig.ui b4b8d37 > src/scriptengine/AmarokScriptableServiceScript.cpp a312671 > > Diff: http://git.reviewboard.kde.org/r/111212/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > script > http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/benchmark.zip > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
